From: Matthias Brugger <matthias.bgg@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Moudy Ho <moudy.ho@mediatek.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
daoyuan huang <daoyuan.huang@mediatek.com>,
Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: platform: mtk-mdp3: fix error code in mdp_vpu_dev_init()
Date: Mon, 5 Sep 2022 13:43:55 +0200 [thread overview]
Message-ID: <7b0ce06b-1e56-0db6-c07b-dd2946af6741@gmail.com> (raw)
In-Reply-To: <YxDGFMwyeNXFPaig@kili>
On 01/09/2022 16:47, Dan Carpenter wrote:
> Return a negative error code if mdp_vpu_shared_mem_alloc() fails.
>
> Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c
> index 9f5844385c8f..a72bed927bb6 100644
> --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c
> +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c
> @@ -173,7 +173,8 @@ int mdp_vpu_dev_init(struct mdp_vpu_dev *vpu, struct mtk_scp *scp,
> /* vpu work_size was set in mdp_vpu_ipi_handle_init_ack */
>
> mem_size = vpu_alloc_size;
> - if (mdp_vpu_shared_mem_alloc(vpu)) {
> + err = mdp_vpu_shared_mem_alloc(vpu);
> + if (err) {
> dev_err(&mdp->pdev->dev, "VPU memory alloc fail!");
> goto err_mem_alloc;
> }
prev parent reply other threads:[~2022-09-05 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 14:47 [PATCH] media: platform: mtk-mdp3: fix error code in mdp_vpu_dev_init() Dan Carpenter
2022-09-02 9:11 ` AngeloGioacchino Del Regno
2022-09-05 11:43 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b0ce06b-1e56-0db6-c07b-dd2946af6741@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=daoyuan.huang@mediatek.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=ping-hsun.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox