From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: david@ixit.cz, Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
Petr Hodina <phodina@protonmail.com>,
Casey Connolly <casey.connolly@linaro.org>,
"Dr. Git" <drgitx@gmail.com>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Joel Selvaraj <foss@joelselvaraj.com>,
Kieran Bingham <kbingham@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH WIP v4 8/9] media: qcom: camss: csiphy-3ph: C-PHY needs own lane configuration
Date: Sun, 29 Mar 2026 12:21:34 +0100 [thread overview]
Message-ID: <7b580a09-672d-4e9a-b2df-0b931d00a5f2@linaro.org> (raw)
In-Reply-To: <10c3e5f1-b078-4b48-bfc6-32199270b86b@linaro.org>
On 03/03/2026 09:59, Bryan O'Donoghue wrote:
> On 01/03/2026 00:51, David Heidelberg via B4 Relay wrote:
>> @bod
>> Proliferating special cases in switch statements on a per-SoC basis is
>> verboten.
>
> Hmm, your ideas are intriguing to me, and I wish to subscribe to your
> newsletter.
>
> ---
> bod
>
@David.
I'm realising my Simpson's reference probably isn't actionable
development feedback ;)
How about embeddding a pointer to either a DPHY or CPHY init sequence
somewhere and checking that pointer ?
If it the CPHY init sequence/table in this case, is NULL return
-EOPTNOTSUPP.
That way instead of constantly extending a switch for each new SoC we
enumerate a pointer and check that pointer's validity.
Then we have nice clean code which just checks the value of a pointer,
instead of an ever-growing list of SoCs in a switch.
---
bod
next prev parent reply other threads:[~2026-03-29 11:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 0:51 [PATCH WIP v4 0/9] media: camss: Add support for C-PHY configuration on Qualcomm platforms David Heidelberg via B4 Relay
2026-03-01 0:51 ` [PATCH WIP v4 1/9] media: qcom: camss: csiphy: Introduce PHY configuration David Heidelberg via B4 Relay
2026-03-03 9:48 ` Bryan O'Donoghue
2026-03-01 0:51 ` [PATCH WIP v4 2/9] media: qcom: camss: csiphy-3ph: Use odd bits for configuring C-PHY lanes David Heidelberg via B4 Relay
2026-03-03 9:52 ` Bryan O'Donoghue
2026-03-01 0:51 ` [PATCH WIP v4 3/9] media: qcom: camss: Prepare CSID for C-PHY support David Heidelberg via B4 Relay
2026-03-03 9:53 ` Bryan O'Donoghue
2026-03-03 20:31 ` David Heidelberg
2026-03-01 0:51 ` [PATCH WIP v4 4/9] media: qcom: camss: Initialize lanes after lane configuration is available David Heidelberg via B4 Relay
2026-03-03 9:54 ` Bryan O'Donoghue
2026-03-03 10:06 ` David Heidelberg
2026-03-03 10:10 ` Bryan O'Donoghue
2026-03-03 10:12 ` David Heidelberg
2026-03-01 0:51 ` [PATCH WIP v4 5/9] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 MIPI CSI-2 CPHY init David Heidelberg via B4 Relay
2026-03-01 0:51 ` [PATCH WIP v4 6/9] media: qcom: camss: csiphy-3ph: Update " David Heidelberg via B4 Relay
2026-03-03 9:55 ` Bryan O'Donoghue
2026-03-03 10:00 ` David Heidelberg
2026-03-03 10:08 ` Bryan O'Donoghue
2026-03-03 10:22 ` Konrad Dybcio
2026-03-03 10:27 ` David Heidelberg
2026-03-03 10:39 ` Bryan O'Donoghue
2026-03-03 10:46 ` Konrad Dybcio
2026-03-01 0:51 ` [PATCH WIP v4 7/9] media: qcom: camss: csiphy-3ph: Add Gen2 v1.2.1 MIPI CSI-2 C-PHY init David Heidelberg via B4 Relay
2026-03-03 9:56 ` Bryan O'Donoghue
2026-03-01 0:51 ` [PATCH WIP v4 8/9] media: qcom: camss: csiphy-3ph: C-PHY needs own lane configuration David Heidelberg via B4 Relay
2026-03-03 9:59 ` Bryan O'Donoghue
2026-03-29 11:21 ` Bryan O'Donoghue [this message]
2026-03-01 0:51 ` [PATCH WIP v4 9/9] media: qcom: camss: Account for C-PHY when calculating link frequency David Heidelberg via B4 Relay
2026-03-03 10:07 ` Bryan O'Donoghue
2026-03-20 19:48 ` Cory Keitz
2026-03-02 18:43 ` [PATCH WIP v4 0/9] media: camss: Add support for C-PHY configuration on Qualcomm platforms Cory Keitz
2026-03-02 23:13 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b580a09-672d-4e9a-b2df-0b931d00a5f2@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=casey.connolly@linaro.org \
--cc=david@ixit.cz \
--cc=drgitx@gmail.com \
--cc=foss@joelselvaraj.com \
--cc=kbingham@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mchehab@kernel.org \
--cc=phodina@protonmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox