Re: [PATCH v4l-utils] Add missing allocation failure check

[Hans Verkuil <hverkuil+cisco@kernel.org>]

No commit message, improper indentation, and not really worth the effort for
a simple userspace utility.

Sorry, I'm rejecting this patch.

Regards,

	Hans

On 17/07/2026 18:54, Sai Vishnu M wrote:
> Signed-off-by: Sai Vishnu <saivishnu725@gmail.com>
> ---
>  utils/common/keymap.c | 11 ++++++++++-
>  1 file change
>  d, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/common/keymap.c b/utils/common/keymap.c
> index 21c1c0b5..b881187a 100644
> --- a/utils/common/keymap.c
> +++ b/utils/common/keymap.c
> @@ -124,7 +124,11 @@ static error_t parse_plain_keymap(char *fname, struct keymap **keymap, bool verb
>  							struct keymap *k;
>  
>  							k = calloc(1, sizeof(*k));
> -							k->protocol = strdup(p);
> +                            if (!k) {
> +								perror("parse_keymap");
> +								return ENOMEM;
> +							}
> +                            k->protocol = strdup(p);
>  							k->next = map->next;
>  							map->next = k;
>  						}
> @@ -399,6 +403,11 @@ static error_t parse_toml_protocol(const char *fname, struct toml_table_t *proot
>  			struct protocol_param *param;
>  
>  			param = malloc(sizeof(*param));
> +			if (!param) {
> +				perror("parse_toml_protocol");
> +				free_keymap(map);
> +				return ENOMEM;
> +			}
>  			param->name = strdup(key);
>  			param->value = value;
>  			param->next = map->param;