Linux Media Controller development
 help / color / mirror / Atom feed
From: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bryan O'Donoghue <bod@kernel.org>,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Stephan Gerhold <stephan.gerhold@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Johan Hovold <johan+linaro@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>,
	Mansur Alisha Shaik <mansur@codeaurora.org>,
	Andy Gross <andy.gross@linaro.org>,
	Rob Clark <robin.clark@oss.qualcomm.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Yassine Oudjana <y.oudjana@protonmail.com>,
	Pierre-Hugues Husson <phhusson@freebox.fr>,
	Marc Gonzalez <mgonzalez@freebox.fr>,
	cros-qcom-dts-watchers@chromium.org,
	Matthias Kaehlcke <mka@chromium.org>,
	Douglas Anderson <dianders@chromium.org>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Aniket Masule <amasule@codeaurora.org>,
	Malathi Gottam <quic_mgottam@quicinc.com>,
	Rajendra Nayak <quic_rjendra@quicinc.com>,
	Jonathan Marek <jonathan@marek.ca>,
	Dikshita Agarwal <dikshita@qti.qualcomm.com>,
	Renjiang Han <quic_renjiang@quicinc.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Daniel J Blueman <daniel@quora.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH 04/22] arm64: dts: qcom: hamoa: Reserve low IOVA range for Iris
Date: Mon, 10 Aug 2026 22:27:31 +0530	[thread overview]
Message-ID: <7caa7fd4-6732-4c80-8b8e-a0ed99631ba2@oss.qualcomm.com> (raw)
In-Reply-To: <v7vlh2lgvluvacmxora6l7u5r3cbhr4xaqqlzqdli5jympfwxl@5qsqc354n4u3>



On 8/10/2026 5:40 PM, Dmitry Baryshkov wrote:
> On Sat, Aug 08, 2026 at 09:18:42PM +0530, Vikash Garodia wrote:
>>
>>
>> On 8/7/2026 6:48 PM, Bryan O'Donoghue wrote:
>>> On 07/08/2026 11:22, Vikash Garodia wrote:
>>>>>>> I don't like the idea of this series, because it_again_
>>>>>>> doesn't tell us
>>>>>>> the truth about the hardware. This typicall ends up with
>>>>>>> bigger problems
>>>>>> honestly...thats all the info i have about the vpu hardware that it
>>>>>> restricts non pixel to DMA from the 0-600MB range. The same i have been
>>>>>> trying for a year now
>>>>> You are not honest here. You also know that there are secure streams,
>>>>> which have to use their own IOMMU SIDs. And some of them, as far as I
>>>>> remember, also have memory range restrictions.
>>>> please read the commit description again, the answer is there.
>>>
>>> So I don't necessarily get all of the detail out of the commit log myself.
>>>
>>> Could you give some detail to address Dmitry's point.
>>>
>>> The question as I read it is - are all of the other potential SIDs
>>> covered by this change ?
>>>
>>
>> I get the query as "secure streams also have their dedicated reserve
>> regions, so how does this approach helps" - This patch does not reserve any
>> IOVA for secure streams, only the forward looking subnode can assign
>> specific reserve for specific streams.
>> The patch enforces a common IOVA across all streams, and is good enough to
>> fix the problem we have w.r.t device reset.
> 
> No, it's not good enough. It defines that both non-secure streams use
> the provided memory range, it doesn't provide a natural way to later
> _expand_ it to support secure subnodes, etc.
> 
> We know that there is a problem. We already have been bitten by not
> describing the hardware as is and using band-aids. Can we now learn the
> lesson and write a proper hardware description?
> 
>>
>>>>> So, if we land these patches, how do extend it later to account for all
>>>>> of that?
>>>>>
>>>> forward looking design would be subnode, which we can land ontop of this
>>>> series.
>>>
>>> Yes it should be possible to branch to make subnodes work on-top of this
>>> - accepting that once this lands it becomes ABI and support for this
>>> method must be sustained, even after sub-nodes land.
>>>
>>
>> Thats the plan. This goes as ABI with subnode to land on top of it.
> 
> So, do you actually plan to support both ABIs? This would also mean
> moving reserved regions to the subnode. 

How is that different from moving the reserve region when stream IDs 
would also need to move, so be it for the associated memory regions.

> What prevents us from landing subnodes straight away?
> 

You are well aware of them, but still asking the same. Reasons,
1. We have been attempting the subnodes for almost a year with multiple 
pushbacks from multiple maintainers. We are closer and working on it to 
post for iris, followed by venus, once review is acceptable for iris.
2. Current solution, in this series, is much easy to apply for all 
kernels and can land faster so that it can fix the reset issue we have 
for already enabled devices.

Both from timewise and simplicity wise, this proposal is made to address 
the reset issue, while subnode can land ontop of this, without breaking ABI.

Regards,
Vikash


  reply	other threads:[~2026-08-10 16:57 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5BXSXMNl656WiJPJAMmHvb3I2NzYMshRZuGuub3CxEXvdCUlIDKYbnv5jUq-pa6P1NibBLkO3njnKGxi7Al3jQ==@protonmail.internalid>
2026-08-07  8:24 ` [PATCH 00/22] media: iris: Restrict lower IOVA range for Venus and Iris VPUs Vikash Garodia
2026-08-07  8:24   ` [PATCH 01/22] dt-bindings: media: qcom,venus-common: Allow IOVA reservation memory-region Vikash Garodia
2026-08-07  8:24   ` [PATCH 02/22] dt-bindings: media: qcom,sm8550-iris: " Vikash Garodia
2026-08-07  9:01     ` Dmitry Baryshkov
2026-08-07  8:24   ` [PATCH 03/22] dt-bindings: media: qcom,sc7180-venus: " Vikash Garodia
2026-08-07  8:24   ` [PATCH 04/22] arm64: dts: qcom: hamoa: Reserve low IOVA range for Iris Vikash Garodia
2026-08-07  9:03     ` Dmitry Baryshkov
2026-08-07  9:26       ` Vikash Garodia
2026-08-07 10:00         ` Dmitry Baryshkov
2026-08-07 10:22           ` Vikash Garodia
2026-08-07 13:18             ` Bryan O'Donoghue
2026-08-08 15:48               ` Vikash Garodia
2026-08-10 12:10                 ` Dmitry Baryshkov
2026-08-10 16:57                   ` Vikash Garodia [this message]
2026-08-07 16:24       ` Rob Herring
2026-08-08  4:37         ` Vishnu Reddy
2026-08-08  9:55           ` Bryan O'Donoghue
2026-08-10 13:47             ` Rob Herring
2026-08-07  8:24   ` [PATCH 05/22] arm64: dts: qcom: lemans: " Vikash Garodia
2026-08-07  8:24   ` [PATCH 06/22] arm64: dts: qcom: monaco: " Vikash Garodia
2026-08-07  8:24   ` [PATCH 07/22] arm64: dts: qcom: sc8280xp: " Vikash Garodia
2026-08-07  8:24   ` [PATCH 08/22] arm64: dts: qcom: sm8350: " Vikash Garodia
2026-08-07  8:24   ` [PATCH 09/22] arm64: dts: qcom: sm8550: " Vikash Garodia
2026-08-07  8:24   ` [PATCH 10/22] arm64: dts: qcom: sm8650: " Vikash Garodia
2026-08-07  8:24   ` [PATCH 11/22] arm64: dts: qcom: sm8750: " Vikash Garodia
2026-08-07  8:24   ` [PATCH 12/22] arm64: dts: qcom: agatti: Reserve low IOVA range for Venus Vikash Garodia
2026-08-07  8:24   ` [PATCH 13/22] arm64: dts: qcom: kodiak: " Vikash Garodia
2026-08-07  8:24   ` [PATCH 14/22] arm64: dts: qcom: msm8916: " Vikash Garodia
2026-08-07  8:24   ` [PATCH 15/22] arm64: dts: qcom: msm8996: " Vikash Garodia
2026-08-07  8:25   ` [PATCH 16/22] arm64: dts: qcom: msm8998: " Vikash Garodia
2026-08-07  8:25   ` [PATCH 17/22] arm64: dts: qcom: sc7180: " Vikash Garodia
2026-08-07  8:25   ` [PATCH 18/22] arm64: dts: qcom: sdm630: " Vikash Garodia
2026-08-07  8:25   ` [PATCH 19/22] arm64: dts: qcom: sdm845: " Vikash Garodia
2026-08-07  8:25   ` [PATCH 20/22] arm64: dts: qcom: sm6115: " Vikash Garodia
2026-08-07  8:25   ` [PATCH 21/22] arm64: dts: qcom: sm8250: " Vikash Garodia
2026-08-07  8:25   ` [PATCH 22/22] arm64: dts: qcom: talos: " Vikash Garodia
2026-08-07  8:51   ` [PATCH 00/22] media: iris: Restrict lower IOVA range for Venus and Iris VPUs Bryan O'Donoghue
2026-08-07  8:59   ` Dmitry Baryshkov
2026-08-07  9:05     ` Vikash Garodia
2026-08-07 10:01       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7caa7fd4-6732-4c80-8b8e-a0ed99631ba2@oss.qualcomm.com \
    --to=vikash.garodia@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=amasule@codeaurora.org \
    --cc=andersson@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bod@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=daniel@quora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=dikshita@qti.qualcomm.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=johan+linaro@kernel.org \
    --cc=jonathan@marek.ca \
    --cc=jorge.ramirez@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mansur@codeaurora.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mgonzalez@freebox.fr \
    --cc=mka@chromium.org \
    --cc=neil.armstrong@linaro.org \
    --cc=phhusson@freebox.fr \
    --cc=quic_mgottam@quicinc.com \
    --cc=quic_renjiang@quicinc.com \
    --cc=quic_rjendra@quicinc.com \
    --cc=robh@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sboyd@codeaurora.org \
    --cc=stable@vger.kernel.org \
    --cc=stanimir.k.varbanov@gmail.com \
    --cc=stanimir.varbanov@linaro.org \
    --cc=stephan.gerhold@linaro.org \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox