Re: [RFC PATCH v1 4/5] media: tegra: Add Tegra Video input driver for Tegra210

Thierry Reding
2020-01-29T10:09:15Z

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

On Tue, Jan 28, 2020 at 02:13:17PM -0800, Sowjanya Komatineni wrote:
> On 1/28/20 1:45 PM, Helen Koike wrote:
[...]
> > On 1/28/20 4:23 PM, Sowjanya Komatineni wrote:
[...]
> > > +const struct tegra_csi_fops csi2_fops = {
> > > + .hw_init = csi2_hw_init,
> > > + .csi_start_streaming = csi2_start_streaming,
> > > + .csi_err_status = csi2_error_status,
> > > +};
> > If I saw correctly, you don't have other instances of struct tegra_csi_fops with different functions.
> > So why not exposing the functions directly instead of creating a global variable?
> Currently driver supports Tegra210 only. Later we will add for Tegra186 and
> Tegra184 support too where we will have separate csi fops.

Perhaps this structure should be prefixed with a tegra210_ to make that
more obvious?

> > > +EXPORT_SYMBOL(csi2_fops);

Also, why do we need to export these? These will be built as linked into
the Tegra VI driver, which is the only one that uses these, right? Would
it not be enough to just make it global? Why the need to export?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]