From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 492832F7F11 for ; Tue, 7 Jul 2026 07:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783407760; cv=none; b=FwmsyLgNngTsndOrIax01LzyPio3wpAHgV4Ou7wNc+nKh3JsZ4aT21kXBkRWcPWkjEt1cv/3kbv1/jp2ZQGXlM9ZCHHE7I11qQ5vInm5Y+tls2iS874TN6hSut/31qlfrrag0I7LQNL3VfuPkJKvG4X+G5XV2j6sfg1AArQluaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783407760; c=relaxed/simple; bh=jl83pEmrNHAO9lFjv2bO3JFx4Sg2A+9IFEDUgOi/Lkg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nwfSEodvIoI/0bEUdkttb1BjhFY3FbYiJYIkmWgWdIzSos1xZ1Lx0REicX9i0//VN0MRuSyPRiY79fBhq6Ld5wLUdoqiyKMUfHoFxchdNKvYV/GH3D/qBQ7uyIBD00C8M3JeCn6idKYGuIo3wsYE4uqNPtHfW3rPdJO1iSqeX5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DfbDOWOG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h8zwXRpc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DfbDOWOG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h8zwXRpc" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66748fWP2449650 for ; Tue, 7 Jul 2026 07:02:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qK3xL2jl8ebZt5swKuGJNP6ZXB3JUsVz/zPHOxlYvAE=; b=DfbDOWOGHhgzGyvQ BPWt0YefggapcaC+j0nI1TgdW40KO5qcdKGEvuiVuMSPfHz15m5kRmw/s/OcTNRz 8CfiGJAypmP7jSo7FlHm4EuJ0uBtfPTfQ80lTUBLW3Q/BJItnIGHd7uupkr5QVAa 11BhU/VbFzARBI77crz0pNfH96jEG+AQqKNeAK47oE7dUy0B6EJ9QuJQV9m6JagJ rNz3oJXv+xDHeGprPBxBGctymnyqVekFdXfgcdsz5sGMuL8L/NT1EohhvXatlz1r mJKLFAUPuk0WQ/rgJXDcO+ESPvPEyEdELSFaKD1uZuLmOd4FyKTXYPOFN0Uid+/l ndfeng== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8su70mcf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 07:02:38 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c85a298cd62so3481738a12.0 for ; Tue, 07 Jul 2026 00:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783407758; x=1784012558; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qK3xL2jl8ebZt5swKuGJNP6ZXB3JUsVz/zPHOxlYvAE=; b=h8zwXRpcLtI4j0fjHs3keZliKt6NqD54XI4SYBBenVf/zrPxc4O/J7FWfZbwQgGpZ+ UlGiQ5X805kfbmlobdVoYTeROEwgvau7ttMECTm5SlOYI1PHelyi3yJexIHQ6oX+dX38 rXMTp8O9yjCqJKSmp9JPS5Nl/FRhiyAsEbzj/dNW/ZyGrhO6RmPtcazgqRafLSTp31YN toJe3EozITkdeu9rx94PPASD1qN2RYK/yljvyAoMhOpkD6HgkhS/9umxB6whXeEzhqK/ xAxU/Vf9d+qt4bPjpuCr5NEtjPlDbD9Dl047OQe3crJeH0oPlgsGgMeIj6G2mCddxbFl futQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783407758; x=1784012558; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qK3xL2jl8ebZt5swKuGJNP6ZXB3JUsVz/zPHOxlYvAE=; b=neWlcbOY2udZ1/3V6/l1rEOcKuZKYLTz2HUTlg/UFkDpnqYXpQ1MaMEAk42xGIoamB RF69PcrXVKuT2+/bWBV7a8uQZEYWtiyowrX7p4UCGlFCjozYi6d5XF+TBPUrs9cTAu/y +K89LAn+CrQmMqxGh0zniGEt2rGmO7V+0BVZyaBV1psAJHxHuRp2nccaD+bvAOLR1Whp aHjwcE3onPJ5iapZ7ucJXrFD0VCXEuyqKkk74Ea1WQJEJj4IZb+MjRhrPiG7FkZkwveS v0Pui/VG3rs8xDlC/O+nZe34Dsk0E9zDL2kphmj+HXfw9pjUITbfoN93iUQK5AOZnGyB ccag== X-Forwarded-Encrypted: i=1; AHgh+RqbbMSPStuwuARLRXRQXEtZrD/H3XXuaWUQOh8B9tZptCbbdSCM9Xtdbsej4koRUiJCEeqTRJC3euObqA==@vger.kernel.org X-Gm-Message-State: AOJu0YzldxKutqryqs+wiBgKYK/4AZbgbWevKGXQLLnB+ve4g44DqK/b yXA3Pvxi4yz4bxp/Otso1rq8XlCp8B71f7ccYHGtSblpPtBh+jo8xIr9NfCD+6E3NA/NlwlqtB/ gqs9vfQCIc45tpRRQWE6k5/1kNrIB7afwz/pY7GfOQK4kJm7OHIMoPHQOqxvlvm68iA== X-Gm-Gg: AfdE7cktExizZn6YNfe248q92XLhZfcGHjJnA9VX6Q1rz/UMgSNpzlblE4DHgOP3Fkr 8dNalb1GXtfv03kB6FUFud6rM2HCiBcdqlcqcH61CgPQLTihNuJIksgRYiBBYvCghi11Tgft0UD 5HAk7jGF9+1nsNuTOiDpQqGtf7K2cK1eR4shwge13XQPJ0XlAIEV3vIzXM1WenJrKZa7Ts1eRyg l7fFAifvWAu1OiZoOhVwEJ/N0X0Ju2LlZTnt4zgLQKw1IqhpNUsce5rCSDQ9j8WE6q0SXpzYWyP k8zgAAs3HTZ9WaNTp1dZ0bkXnjTajPmzefmC4mmeAqhjjRTSErNFhTvz/ug4OJqQtjYXAcGciE2 TxV+EHm5gweB7jyF7jk5p+36G8LTf1Ebp9+yI0n8iBccc X-Received: by 2002:a05:6a20:939d:b0:3bf:f795:f0f3 with SMTP id adf61e73a8af0-3c08ef55bb8mr5389209637.54.1783407757783; Tue, 07 Jul 2026 00:02:37 -0700 (PDT) X-Received: by 2002:a05:6a20:939d:b0:3bf:f795:f0f3 with SMTP id adf61e73a8af0-3c08ef55bb8mr5389153637.54.1783407757293; Tue, 07 Jul 2026 00:02:37 -0700 (PDT) Received: from [10.204.101.214] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659d7c8bsm4912010c88.12.2026.07.07.00.02.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 00:02:36 -0700 (PDT) Message-ID: <7e4765be-397d-4efd-b8bb-5e990addf4f8@oss.qualcomm.com> Date: Tue, 7 Jul 2026 12:32:30 +0530 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] media: iris: add new rate control type MBR for encoder To: Sachin Kumar Garg , Dmitry Baryshkov , Nicolas Dufresne Cc: Konrad Dybcio , Mauro Carvalho Chehab , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260213-b4-add_sc7280_mbr-v1-0-e8d95b4e4809@oss.qualcomm.com> <20260213-b4-add_sc7280_mbr-v1-2-e8d95b4e4809@oss.qualcomm.com> <84895cad-9f1a-4e51-8e43-faf30b4bdabb@oss.qualcomm.com> <7f165169-427b-4f5b-9bee-bb227be23d82@oss.qualcomm.com> <69fea3d9214405996d2ecc50419e539e84f22a3a.camel@ndufresne.ca> Content-Language: en-US From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDA2NSBTYWx0ZWRfX7z9IW3MVcwHg E702E35q8DFld1Yn3x2pyDrjWoWv2ZtL+ivhxxD6Y1e9iQgUrOMN7Vprlpd/e/BLRweyOql7Ysu /f0GQSi20Zb+3bv12bpRcfB1lxlvbpiJ8OMQBMmo3NeBTUGS9qYv2Y0C+ZQzhEnnZ2HPQ58CMPI RmapGpvT+vf73LMlB9i9tweqOAdiziF6qsNs+yRZRXk4Z/NC06l7P2AxpzeMh0jdyr0lEi/aGfp jnkxDyFu86nJI8yis1D16JzrlXhfJN5NwHA038hzdKwDGDCZVQJK+ALKACT3fpj4oHlLoM3feAi DVvmD4wtwTEkCcPq54Zc0bxK+DNZJvuKOsK+D7eqw71aGhUxXODgS0+a05Artlu/dRFFd4m89Ys 6DgnuTU4N4RZBPTKv7h4wso22LungS69jGNq2TS21r95QQ+Gao/P0ekF40MJymzE966YomOviOs VqF4v/8kC9IGduDL6wg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDA2NSBTYWx0ZWRfX6vkXPmQvT/Cr neZ3YbPaE1H3AG/KNsMxHlqtvseuVEOYS7WeI3P43T6HqU+5CaJNbvt9sa9/P/vBReu7fUDnaP7 IXWIxAvwRWoTIFOE+r8LOeBlqwK5nmc= X-Proofpoint-GUID: 1870CIGLy6eRr4_vX8JrrDPfmBA3fOaC X-Proofpoint-ORIG-GUID: 1870CIGLy6eRr4_vX8JrrDPfmBA3fOaC X-Authority-Analysis: v=2.4 cv=HN7z0Itv c=1 sm=1 tr=0 ts=6a4ca48e cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=9AdMxfjQAAAA:20 a=YSFRvgiz6-i7QfQYUPUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_01,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070065 On 3/30/2026 11:14 AM, Sachin Kumar Garg wrote: > > > On 3/17/2026 12:17 AM, Dmitry Baryshkov wrote: >> On Mon, Mar 16, 2026 at 01:37:21PM -0400, Nicolas Dufresne wrote: >>> Le lundi 16 mars 2026 à 11:52 +0530, Sachin Kumar Garg a écrit : >>>> >>>> >>>> On 2/13/2026 3:24 PM, Konrad Dybcio wrote: >>>>> On 2/13/26 7:04 AM, Sachin Kumar Garg wrote: >>>>>> Introduce V4L2_MPEG_VIDEO_BITRATE_MODE_MBR rate control to Encoder. >>>>>> Encoder will choose appropriate quantization parameter and >>>>>> do the smart bit allocation to set the frame maximum bitrate >>>>>> level as per the Bitrate value configured. >>>>>> --- >>>>>>    drivers/media/platform/qcom/iris/iris_ctrls.c      |   2 + >>>>>>    .../platform/qcom/iris/iris_hfi_gen1_defines.h     |   1 + >>>>>>    .../media/platform/qcom/iris/iris_platform_gen1.c  |   9 +- >>>>>>    .../platform/qcom/iris/iris_platform_sc7280.h      | 202 >>>>>> +++++++++++++++++++++ >>>>> >>>>> Is this really only available on 7280? >>>>> >>>>> Konrad >>>> >>>> Yes Konrad, in this series we enable V4L2_MPEG_VIDEO_BITRATE_MODE_MBR >>>> only for SC7280 because currently, we have added the support only for >>>> low tier chipset. MBR rate control aims to improve the compression >>>> efficiency of encoder for static and low motion scenes for extremely >>>> low >>>> bitrate use-case. >>> >>> Without a spec definition, which constrained the implementations toward >>> interoperability, this needs to be made vendor specific. That being >>> said, even >>> as vendor specific control, I think it deserves more documentation >>> for your >>> users. >> >> What kind of documentation would be a better fit for keeping this in the >> generic namespace? Frankly speaking, I think that the current >> documentation is too vendor-specific, it describe the particular >> algorithm, while the control seems to be more generic. However, I also >> feel that defining it as "Maximum Bitrate" might not be specific enough >> (nor would it show a difference from the CBR mode). >> >> > Thanks for the suggestion. > I understand that this functionality is vendor-specific and should not > be exposed via a generic control. Would it be acceptable to convert this > into a vendor-specific control (for example, > V4L2_MPEG_VIDEO_BITRATE_MODE_QCOM_MBR) and update the documentation > accordingly? > Please let me know if this aligns with upstream expectations, or can you > please suggest if there is any other preferred approach for adding > vendor-specific controls in this case. I discussed this with Hans during embedded conference on handling vendor specific controls. His suggestion was that vendor can define a reserve for 16/32/64 controls, something similar to [1], for cases like this which seems quite vendor specific handling to me. [1] https://github.com/torvalds/linux/blob/0e35b9b6ec0ffcc5e23cbdec09f5c622ad532b53/include/uapi/linux/v4l2-controls.h#L235 Regards, Vikash > > Thanks, > Sachin