From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D05739D6DE for ; Thu, 30 Apr 2026 18:18:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777573129; cv=none; b=qh0rrY7NRNRT8C9/OHEQfTzTLKnlfP4s7Rfz7/f0SJ7lJUBGYfugZKjz+Qh72BKIHzz/PuYiKBtEhMp6bokXnauFDQxGH3b7u2YzpKNiJ4QpUKQ5p2fOANvNi6xNGgtveAExFcYowFTUneHorcELBQCZxOfgTxlFSIQEMOO0UQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777573129; c=relaxed/simple; bh=ML7iINJjRH4Gzjw9niY8gGNr83rzlZiUCq+9OWPM3vM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gyBo+LK8kjX1R6+j7wLBHewUrHLNh+mE5gbNosqL90XnCvYMZ8b5W0+emgyh2l+JWFyKPtHkkYSRuMJov2Vri8SkwbGt6W95wmrI0jmtnEjlyDha7qQ/+zvQM0B3V3FGXUPRaEmeoLU38S1OQ1VzaujcLtbWy6Vw7ttgyQGkb2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M6ffAm8E; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M6ffAm8E" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4896c22fcbaso9157255e9.0 for ; Thu, 30 Apr 2026 11:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777573126; x=1778177926; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+sxVPeWzK/5JcscdkmY85m6FCWps4Q/alwynbpD7Pbo=; b=M6ffAm8E/r1bGQBMqCF1p483D6nCifjpf3Dvf/n5RLt7zojYsQeA4OkChPnvHkN1lR a/6W5fxkqPhlx1cTIQIvj+kwr/YERqxCSmggYnfZOmvTiFFIQ09v5D/CoEZBzgMO6W7l wn/udkFL9WkaeKjnCg73Jk9aWL+NBuCULSuqKPsA8/Rb/vS4o8DysSNwn8cfMAYzW6yd X1HitFTmsQJkPmyznFkdxs1S/tUG9VypPy0YaqJtPIN7czKDfbiZxZOTdZsnx619bJMN eRGaG4gfwCPfDx1J+URaLMlTdez3lJyDuydWgmUqksjNcPWygKvXXhxdpjRQ1PikurOf IqzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777573126; x=1778177926; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+sxVPeWzK/5JcscdkmY85m6FCWps4Q/alwynbpD7Pbo=; b=S+/DQyV3c9LlqGQRdmCT2TnfmsEKuCK1ljYjI9vkLnMwwWhIoxsProw3nNzRP5ZOkF S+N3GFWQRQyx19u/zFNP7/58+fCRx47wXM79hcp+Rhbenweo8tAVCPRYF5+Aa6TbGl/v Wws2lmy+kNvo0u6NIyhcXiRTscztu3R0e8EV+EInRi2LKPdnkUDKe1QYKU8JHVV/ESp3 sLJIkCxXYC8NOrZd7J0T5jeCzH4nZ7PibV45fVOQ3Y5V2E5RiUWwpxBGt6iNH4pyDEkX 3H60jgRmm/RdeykHSUfHWzUzCdEh7WgTClFkUyhRFJ8yXQNmIIdrN8/Ttaw9TJoOijHG Mj6g== X-Forwarded-Encrypted: i=1; AFNElJ/YmeDSrs1d79PgDk01wLExso3TxMIl6czni5LJVd9RH9SNpmM5lQ2pKwYKsGxvcDnNd6DIirUBnBxMOg==@vger.kernel.org X-Gm-Message-State: AOJu0YyOCRrmPQjK8HF2zOzCh5LJTE4pJ8ZWmYODErXHMdvJv+EzZucn rYnsR/xARNA6BODR4PXqpYIkT7jbLSMrj3zi/0buMG3hw+XxzGRLuM2S X-Gm-Gg: AeBDieuzpgo/bNVh6ZKxcd+Q0tqr4pqhPFAO92ckurTlLirbxzxho9BVufrgRrbhU6V +5UPSn/h2Sc1j9rXvV1Ni7F4WVCgUnC5SA6D7h94IRdQtzc2kbH7wRKV3wEV1x4lb69r4boMMSP tO8uE46OTGI1ARWnF4grLaoL4bqLPDFRa/hpWQEul6evm5MVyePOAow0g97P3E2k/CFKghBpn4f 1i/J6fYn56F1DsZVMpVMuVL/UJQKWdwBu+CuwJPkTaJ4fGfFxSG2YVYbuvP0mCCPbN7IYIl5x28 i5ypvQA0SYzFSd3evwY7a/wchvcvK0OebAeUhM4f8nHAzyJwodjwmZR/YB7/793DVtkl8VtDkC8 BaBAiSKfBkoMB/+VyP1wHDUFqMB43/L3MeMrSTIS5wCz2a99wFPdDwmIB8KMXM0Mbbn8DrdvG+X +scoh9lXbzmZ0iP+qeRE8Wb9/MTOagtJCrLbZuR3yV3yWSNshlKb//AmLUC32Dnk2QhqeiVKkD7 fUCPQ3LlpObejAYa9Sh6aIOtPoeFK+xo5x3JQQerZLsVd088sfgWr6buXfIgxhrp9Bmk2Oj1E6v tA== X-Received: by 2002:a05:600c:3495:b0:48a:5339:ef0e with SMTP id 5b1f17b1804b1-48a83d62ffbmr66464485e9.3.1777573126483; Thu, 30 Apr 2026 11:18:46 -0700 (PDT) Received: from [10.109.92.8] (net-2-37-141-89.cust.vodafonedsl.it. [2.37.141.89]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8d15fdedsm3944495e9.4.2026.04.30.11.18.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 11:18:45 -0700 (PDT) Message-ID: <7f091660-2e60-4de5-a3b7-7b8d206fd6ab@gmail.com> Date: Thu, 30 Apr 2026 19:18:44 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/10] nvme-pci: implement dma_token backed requests To: Maurizio Lombardi , Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Cc: Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Phil Cayton , Jason Gunthorpe References: <5cecb1157ab784f9f303a91449fdf11b03aa6002.1777475843.git.asml.silence@gmail.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/29/26 17:07, Maurizio Lombardi wrote: > On Wed Apr 29, 2026 at 5:25 PM CEST, Pavel Begunkov wrote: >> Enable BIO_DMABUF_MAP backed requests. It creates a prp list for the >> dmabuf when it's mapped, which is then used to initialise requests. >> >> Suggested-by: Keith Busch >> Signed-off-by: Pavel Begunkov >> --- ...>> + >> +static int nvme_create_dmabuf_token(struct request_queue *q, >> + struct io_dmabuf_token *token) >> +{ >> + struct nvme_dmabuf_token *data; >> + struct dma_buf_attachment *attach; >> + struct nvme_ns *ns = q->queuedata; >> + struct nvme_dev *dev = to_nvme_dev(ns->ctrl); >> + struct dma_buf *dmabuf = token->dmabuf; >> + >> + data = kzalloc(sizeof(data), GFP_KERNEL); >> + if (!data) >> + return -ENOMEM; > > Shouldn't this be kzalloc(sizeof(*data)...) ? Good catch, I'll apply it all for next version -- Pavel Begunkov