Linux Media Controller development
 help / color / mirror / Atom feed
From: johannes.goede@oss.qualcomm.com
To: MaximeD <mderaspe@imarcom.net>, linux-media@vger.kernel.org
Cc: mchehab@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: ipu-bridge: Add Dell 14 Premium DA14250 to upside-down DMI table
Date: Mon, 30 Mar 2026 15:26:25 +0200	[thread overview]
Message-ID: <804e6983-d796-4cea-95a3-c8f18a15914e@oss.qualcomm.com> (raw)
In-Reply-To: <20260328150957.22380-1-mderaspe@imarcom.net>

Hi,

On 28-Mar-26 16:09, MaximeD wrote:
> From: Maxime Deraspe <mderaspe@imarcom.net>
> 
> The Dell 14 Premium DA14250 (Lunar Lake) has its ov02c10 front camera
> sensor mounted upside-down, but the ACPI SSDB does not report a 180°
> rotation. Add a DMI quirk entry so that the ipu-bridge driver reports
> the correct rotation, allowing libcamera and applications to display the
> camera image with the proper orientation.
> 
> Signed-off-by: Maxime Deraspe <mderaspe@imarcom.net>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Regards,

Hans


> ---
>  drivers/media/pci/intel/ipu-bridge.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> index b2b710094..2611a96fc 100644
> --- a/drivers/media/pci/intel/ipu-bridge.c
> +++ b/drivers/media/pci/intel/ipu-bridge.c
> @@ -118,6 +118,13 @@ static const struct dmi_system_id upside_down_sensor_dmi_ids[] = {
>  		},
>  		.driver_data = "OVTI02C1",
>  	},
> +	{
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell 14 Premium DA14250"),
> +		},
> +		.driver_data = "OVTI02C1",
> +	},
>  	{} /* Terminating entry */
>  };
>  


      reply	other threads:[~2026-03-30 13:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-28 15:09 [PATCH] media: ipu-bridge: Add Dell 14 Premium DA14250 to upside-down DMI table MaximeD
2026-03-30 13:26 ` johannes.goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=804e6983-d796-4cea-95a3-c8f18a15914e@oss.qualcomm.com \
    --to=johannes.goede@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mderaspe@imarcom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox