From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: rfoss@kernel.org, konradybcio@kernel.org, andersson@kernel.org,
krzk+dt@kernel.org, robh@kernel.org,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 6/6] arm64: dts: qcom: qcm2290: Add CAMSS node
Date: Wed, 16 Apr 2025 16:03:26 +0100 [thread overview]
Message-ID: <80a994f6-c46d-40c2-aaec-33d960cd0dac@linaro.org> (raw)
In-Reply-To: <CAFEp6-0tZQowmDrEsHgU1Ncx6jR2f=Lp259vaj3mefc-9BfUbg@mail.gmail.com>
On 16/04/2025 16:01, Loic Poulain wrote:
>> @5c6e000
>> (first reg entry)
> Ah right, I reordered reg to be aligned with other camss drivers.
> Should I keep that order (and update node name) or reorder with phy
> lower addresses first (PHYs)?
>
>>> + compatible = "qcom,qcm2290-camss";
>>> +
>>> + reg = <0 0x5c6e000 0 0x1000>,
>>> + <0 0x5c75000 0 0x1000>,
>>> + <0 0x5c52000 0 0x1000>,
>>> + <0 0x5c53000 0 0x1000>,
>>> + <0 0x5c6f000 0 0x4000>,
>>> + <0 0x5c76000 0 0x4000>;
>>> + reg-names = "csid0",
>>> + "csid1",
>>> + "csiphy0",
>>> + "csiphy1",
>>> + "vfe0",
>>> + "vfe1";
Please keep consistent with the last committed yaml for CAMSS.
---
bod
next prev parent reply other threads:[~2025-04-16 15:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <yD7X4MYItg2wLMb5iPs1JXadfzhFB7wSFqo_hFbs6K72VbLmTtoOrnwcLJrP4WBvndDUd2eklJl3R4GRWLbl6Q==@protonmail.internalid>
2025-04-16 12:09 ` [PATCH 1/6] media: qcom: camss: Add support for TFE (Spectra 340) Loic Poulain
2025-04-16 12:09 ` [PATCH 2/6] media: qcom: camss: Add CSID 340 support Loic Poulain
2025-04-16 12:09 ` [PATCH 3/6] media: qcom: camss: csiphy-3ph: Add CSIPHY 2ph DPHY v2.0.1 init sequence Loic Poulain
2025-04-16 22:36 ` Dmitry Baryshkov
2025-04-17 8:26 ` Loic Poulain
2025-04-25 19:46 ` Konrad Dybcio
2025-04-16 12:09 ` [PATCH 4/6] media: qcom: camss: add support for QCM2290 camss Loic Poulain
2025-04-16 12:17 ` Bryan O'Donoghue
2025-04-16 15:16 ` Loic Poulain
2025-04-16 15:38 ` Bryan O'Donoghue
2025-04-16 12:09 ` [PATCH 5/6] media: dt-bindings: media: camss: Add qcom,qcm2290-camss binding Loic Poulain
2025-04-16 12:09 ` [PATCH 6/6] arm64: dts: qcom: qcm2290: Add CAMSS node Loic Poulain
2025-04-16 14:46 ` Konrad Dybcio
2025-04-16 15:01 ` Loic Poulain
2025-04-16 15:02 ` Konrad Dybcio
2025-04-16 15:04 ` Bryan O'Donoghue
2025-04-16 15:03 ` Bryan O'Donoghue [this message]
2025-04-16 16:16 ` Loic Poulain
2025-04-16 23:38 ` Bryan O'Donoghue
2025-04-16 12:27 ` [PATCH 1/6] media: qcom: camss: Add support for TFE (Spectra 340) Bryan O'Donoghue
2025-04-16 12:30 ` Bryan O'Donoghue
2025-04-16 13:04 ` Loic Poulain
2025-04-16 14:31 ` Konrad Dybcio
2025-04-16 22:33 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80a994f6-c46d-40c2-aaec-33d960cd0dac@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox