From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: tony@atomide.com
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
linux-media@vger.kernel.org, linux-omap@vger.kernel.org,
khilman@deeprootsystems.com
Subject: Re: [PATCH v5 0/3] OMAP 3 CSI-2 configuration
Date: Thu, 18 Oct 2012 15:45:59 +0200 [thread overview]
Message-ID: <8138988.XlrgGsn68R@avalon> (raw)
In-Reply-To: <1651288.n5DBzW1A1K@avalon>
Hi Tony,
On Tuesday 16 October 2012 16:51:40 Laurent Pinchart wrote:
> Hi Sakari,
>
> Thanks for the patches.
>
> For the whole series,
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Tony, do you want to take patch 1/3 in your tree, or can I push the whole
> series through mine ?
Ping ?
> On Sunday 14 October 2012 13:31:22 Sakari Ailus wrote:
> > Hi all,
> >
> > This is an update to an old patchset for CSI-2 configuration for OMAP 3430
> > and 3630. The patches have been tested on the 3630 only so far, and I
> > don't
> > plan to test them on 3430 in the near future.
> >
> > I've made changes according to Laurent's suggestions to the patches, with
> > the exception of alignment of a certain line. I think it's exactly as it
> > should be. :-)
> >
> > I'm not quite certain about the comment regarding the control register
> > state dependency to the CORE power domain, and why exactly this isn't an
> > issue. We know the MPU must stay powered since the ISP can't wake up MPU,
> > but how is this related to CORE? In the end it seems to work.
> >
> > If you think this should be changed and you also know how, please provide
> > me the text. :-)
> >
> > /*
> >
> > * The PHY configuration is lost in off mode, that's not an
> > * issue since the MPU power domain is forced on whilst the
> > * ISP is in use.
> > */
> >
> > Comments, questions and other kind of feedback is very welcome.
> >
> > Kind regards,
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-10-18 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 10:31 [PATCH v5 0/3] OMAP 3 CSI-2 configuration Sakari Ailus
2012-10-14 10:31 ` [PATCH v5 1/3] omap3isp: Add CSI configuration registers from control block to ISP resources Sakari Ailus
2012-10-14 10:31 ` [PATCH v5 2/3] omap3isp: Add PHY routing configuration Sakari Ailus
2012-10-14 10:31 ` [PATCH v5 3/3] omap3isp: Configure CSI-2 phy based on platform data Sakari Ailus
2012-10-16 14:51 ` [PATCH v5 0/3] OMAP 3 CSI-2 configuration Laurent Pinchart
2012-10-18 13:45 ` Laurent Pinchart [this message]
2012-10-18 15:39 ` Tony Lindgren
2012-10-20 14:11 ` [PATCH v5.1 1/3] omap3isp: Add CSI configuration registers from control block to ISP resources Sakari Ailus
2012-10-20 17:38 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8138988.XlrgGsn68R@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).