From: Jarrah Gosbell <kernel@undef.tools>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Jacob Chen <jacob-chen@iotwrt.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
phone-devel@vger.kernel.org, Ondrej Jirman <megi@xff.cz>
Subject: Re: [PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs
Date: Mon, 15 Aug 2022 08:01:52 +1000 [thread overview]
Message-ID: <821647de-be45-557a-e1eb-2e70e186f2d8@undef.tools> (raw)
In-Reply-To: <CAMdYzYoD9kM_RNs0t=7qc9Tyt9j-cD0DEQD0sR5cEkkGifFSSA@mail.gmail.com>
On 8/14/22 23:12, Peter Geis wrote:
>> ret = rga_parse_dt(rga);
>> - if (ret)
>> + if (ret) {
>> dev_err(&pdev->dev, "Unable to parse OF data\n");
> If this can return EPROBE_DEFER, shouldn't this be dev_err_probe
> instead of dev_err?
Looking into it that does make more sense. I suspect it wasn't done this
way originally because dev_err_probe isn't used elsewhere in rga.c. I'll
send a v2 with that change shortly.
Thanks for the review.
prev parent reply other threads:[~2022-08-14 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-14 4:08 [PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs Jarrah Gosbell
2022-08-14 13:12 ` Peter Geis
2022-08-14 22:01 ` Jarrah Gosbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=821647de-be45-557a-e1eb-2e70e186f2d8@undef.tools \
--to=kernel@undef.tools \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=megi@xff.cz \
--cc=pgwipeout@gmail.com \
--cc=phone-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox