Re: [PATCH v2 1/3] dt-bindings: media: Add bindings for the RZ/V2H IVC block

[Krzysztof Kozlowski <krzk@kernel.org>]

On 24/06/2025 16:17, Dan Scally wrote:
> 
> OK...to throw a spanner into this, I think there's actually two soc codes with the IP; r9a09g057h44 
> and r9a09g057h48. renesas,rzg2l-cru.yaml and renesas,rzg2l-csi2.yaml seem to use the 'generic' code 
> in a way that suggests this:
> 
> compatible:
>          items:
>              - enum:
>                  - renesas,r9a09g057h44-ivc
>                  - renesas,r9a09g057h48-ivc
>              - const: renesas,rzv2h-ivc

There were several reviews where we or at lest me disagreed with above
and explained, with arguments, that this is less welcomed choice.

> 
> 
> And then the filename stays as it is, but the example-schema.yaml to me suggests this, without the 
> 'generic' code there at all:
> 
> 
> compatible:
>          items:
>              - enum:
>                  - renesas,r9a09g057h48-ivc
>              - const: renesas,r9a09g057h44-ivc
> 
> 
> Is the latter one right?

This is the preferred style, yes.


> 
> 
>>
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>> +  clocks:
>>> +    items:
>>> +      - description: Input Video Control block register access clock
>>> +      - description: Video input data AXI bus clock
>>> +      - description: ISP system clock
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: pclk
>>> +      - const: vin_aclk
>> aclk
>>
>> vin is redundant. This cannot be anything else than vin.
> Fair enough; there's also a clock that the documentation calls "reg_aclk" that goes to the ISP core 
> and I've been calling that one just "aclk" so the "vin_" was to distinguish them...but maybe I 

but there is no other aclk here.

> should just stop trying to follow the documentation's names; how about "reg", "axi" and "isp" for 
> both the clock and reset names?

pclk, aclk and sclk are also acceptable names if this is how they are
called in datasheet, but reg, axi and isp seems better reflect the
purpose of these clocks from this device point of view.

Best regards,
Krzysztof