From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH] uvcvideo: Don't call vb2 mmap and get_unmapped_area with queue lock held
Date: Tue, 10 Mar 2015 01:52:02 +0200 [thread overview]
Message-ID: <8389917.WAzPk9jDDo@avalon> (raw)
In-Reply-To: <871tkye8g3.fsf@nemi.mork.no>
Hi Bjørn,
(it took me half an hour to figure out how to write ø on my keyboard :-))
On Monday 09 March 2015 12:06:36 Bjørn Mork wrote:
> Bjørn Mork <bjorn@mork.no> writes:
> > Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:
> >> Bjørn, does this fix the circular locking dependency you have reported in
> >> "[v3.19-rc7] possible circular locking dependency in uvc_queue_streamoff"
> >> ? The report mentions involves locks, so I'm not 100% this patch will fix
> >> the issue.
> >
> > Sorry, I forgot all about that report after firing it off... Should
> > have followed it up with some more details.
> >
> > Grepping my logs now I cannot find this warning at all after the one I
> > reported. I see it once before (while running 3.19-rc6). So it is
> > definitely not easily reproducible. And I have a bad feeling the
> > trigger might involve completely unrelated USB issues...
> >
> > In any case, thanks for the patch. I will test it for a while and let
> > you know if the same warning shows ut with it. But based on the rare
> > occurence, I don't think I ever will be able to positively confirm that
> > the warning is gone.
>
> FWIW, I have not seen the warning after applying this patch, so it
> appears to fix the problem. Thanks.
You're welcome.
> If I'm wrong, then I'm sure Murphy will tell us as soon as I send this
> email :-)
I'd be happy to prove Murphy wrong for once.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2015-03-10 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 18:25 [PATCH] uvcvideo: Don't call vb2 mmap and get_unmapped_area with queue lock held Laurent Pinchart
2015-02-23 9:47 ` Bjørn Mork
2015-03-09 11:06 ` Bjørn Mork
2015-03-09 23:52 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8389917.WAzPk9jDDo@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=bjorn@mork.no \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox