From: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
To: Wangao Wang <wangao.wang@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v4 4/5] arm64: dts: qcom: purwa: Override Iris clocks and operating points
Date: Wed, 1 Apr 2026 18:11:59 +0530 [thread overview]
Message-ID: <849b412b-fd92-d3fd-83bb-f6bbbaed7d12@oss.qualcomm.com> (raw)
In-Reply-To: <20260401-enable_iris_on_purwa-v4-4-ca784552a3e9@oss.qualcomm.com>
On 4/1/2026 3:54 PM, Wangao Wang wrote:
> The Iris block on X1P differs from SM8550/X1E in its clock configuration
> and requires a dedicated OPP table. The node inherited from the X1E cannot
> be reused directly, and the fallback compatible "qcom,sm8550-iris" cannot
> be applied.
>
> Override the inherited clocks, clock-names, and operating points, and
> replaces them with the X1P42100-specific definitions. A new OPP table
> is provided to support the correct performance levels on this platform.
>
> Depends-on: https://lore.kernel.org/all/20260331-purwa-videocc-camcc-v3-0-6daca180a4b1@oss.qualcomm.com/
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/purwa.dtsi | 50 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/purwa.dtsi b/arch/arm64/boot/dts/qcom/purwa.dtsi
> index 70e37fa91f5db83e66f9706b62637f6e18dffa89..c2f4457b83e193cff20120c50b53bf4c67e57239 100644
> --- a/arch/arm64/boot/dts/qcom/purwa.dtsi
> +++ b/arch/arm64/boot/dts/qcom/purwa.dtsi
> @@ -21,6 +21,7 @@
> /delete-node/ &cpu_pd11;
> /delete-node/ &gpu_opp_table;
> /delete-node/ &gpu_speed_bin;
> +/delete-node/ &iris_opp_table;
> /delete-node/ &pcie3_phy;
> /delete-node/ &thermal_aoss3;
> /delete-node/ &thermal_cpu2_0_btm;
> @@ -167,6 +168,55 @@ &gpucc {
> compatible = "qcom,x1p42100-gpucc";
> };
>
> +&iris {
> + compatible = "qcom,x1p42100-iris";
> +
> + clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
> + <&videocc VIDEO_CC_MVS0C_CLK>,
> + <&videocc VIDEO_CC_MVS0_CLK>,
> + <&videocc VIDEO_CC_MVS0_BSE_CLK>;
> + clock-names = "iface",
> + "core",
> + "vcodec0_core",
> + "vcodec0_bse";
> +
> + operating-points-v2 = <&iris_opp_table_x1p42100>;
> +
> + iris_opp_table_x1p42100: opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-210000000 {
> + opp-hz = /bits/ 64 <210000000 105000000>;
> + required-opps = <&rpmhpd_opp_low_svs_d1>,
> + <&rpmhpd_opp_low_svs>;
> + };
> +
> + opp-300000000 {
> + opp-hz = /bits/ 64 <300000000 150000000>;
> + required-opps = <&rpmhpd_opp_low_svs_d1>,
> + <&rpmhpd_opp_svs>;
> + };
> +
> + opp-335000000 {
> + opp-hz = /bits/ 64 <335000000 167500000>;
> + required-opps = <&rpmhpd_opp_svs>,
> + <&rpmhpd_opp_svs_l1>;
> + };
> +
> + opp-424000000 {
> + opp-hz = /bits/ 64 <424000000 212000000>;
> + required-opps = <&rpmhpd_opp_svs>,
> + <&rpmhpd_opp_nom>;
> + };
> +
> + opp-500000000 {
> + opp-hz = /bits/ 64 <500000000 250000000>;
> + required-opps = <&rpmhpd_opp_svs>,
> + <&rpmhpd_opp_turbo>;
> + };
> + };
> +};
> +
> /* PCIe3 has half the lanes compared to X1E80100 */
> &pcie3 {
> num-lanes = <4>;
>
Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Thanks,
Dikshita
next prev parent reply other threads:[~2026-04-01 12:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 10:24 [PATCH v4 0/5] media: iris: add support for purwa platform Wangao Wang
2026-04-01 10:24 ` [PATCH v4 1/5] dt-bindings: media: qcom,sm8550-iris: Add X1P42100 compatible Wangao Wang
2026-04-01 10:48 ` Bryan O'Donoghue
2026-04-02 7:05 ` Krzysztof Kozlowski
2026-04-01 10:24 ` [PATCH v4 2/5] media: iris: Add hardware power on/off ops for X1P42100 Wangao Wang
2026-04-01 10:49 ` Bryan O'Donoghue
2026-04-01 12:37 ` Dikshita Agarwal
2026-04-08 9:14 ` Wangao Wang
2026-04-02 7:08 ` Krzysztof Kozlowski
2026-04-08 9:16 ` Wangao Wang
2026-04-08 10:41 ` Krzysztof Kozlowski
2026-04-14 8:32 ` Wangao Wang
2026-04-01 10:24 ` [PATCH v4 3/5] media: iris: Add platform data " Wangao Wang
2026-04-01 12:40 ` Dikshita Agarwal
2026-04-08 9:17 ` Wangao Wang
2026-04-08 9:20 ` Dikshita Agarwal
2026-04-08 9:22 ` Wangao Wang
2026-04-01 10:24 ` [PATCH v4 4/5] arm64: dts: qcom: purwa: Override Iris clocks and operating points Wangao Wang
2026-04-01 11:03 ` Dmitry Baryshkov
2026-04-01 12:41 ` Dikshita Agarwal [this message]
2026-04-01 10:24 ` [PATCH v4 5/5] arm64: dts: qcom: purwa-iot-som: enable video Wangao Wang
2026-04-01 12:42 ` Dikshita Agarwal
2026-04-02 7:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=849b412b-fd92-d3fd-83bb-f6bbbaed7d12@oss.qualcomm.com \
--to=dikshita.agarwal@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
--cc=wangao.wang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox