From: Krzysztof Kozlowski <krzk@kernel.org>
To: Renjiang Han <quic_renjiang@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Vikash Garodia <quic_vgarodia@quicinc.com>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Nicolas Dufresne <nicolas.dufresne@collabora.com>
Subject: Re: [PATCH v8 0/3] media: venus: enable venus on qcs615
Date: Fri, 6 Jun 2025 09:54:08 +0200 [thread overview]
Message-ID: <85533e92-43bb-40dd-a8d5-13d19e859616@kernel.org> (raw)
In-Reply-To: <e18bdd88-3866-4aef-8873-b9b67f0cb9b7@quicinc.com>
On 06/06/2025 09:51, Renjiang Han wrote:
>>>
>>> Reading this thread, I don't think that is the case.
>>>
>>> I don't see how patches 2/3 or 3/3 depend on 1/3.
>>>
>>> The frequency table is a fallback in the driver and the DT changes
>>> are completely straight forward.
>>>
>>> TBH, I think we are hitting an email comms/social barrier here, not a
>>> technical one.
>>>
>>> @Renjiang can you please confirm that freq_table is a fallback,
>>> qcs615 will work without OPP table and the DTS stuff doesn't depend
>>> on the driver.
>> yes, freq_table is a fallback. driver will use freq_table without OPP
>> table. the DTS doesn't depend on the driver.
> To correct my previous response:
> For this project, the driver patch needs to be merged first. Since it
> falls back to SC7180, but their frequencies are different which is
> reflected in the OPP table defined in the DTS.
>
> The DTS patch is intended to enable video function on the QCS615 platform.
>
> The driver patch is to switch from using the driver freq_table to the
> OPP table from the DTS. Without it, the driver will continue to use the
> internal freq_table as before.
>
> Therefore, if the DTS patch is applied without the driver patch, the video
> function will be enabled on the QCS615 platform, but the driver will use
> the SC7180 frequency table, which can lead to an overclocking issue.
This means devices are not really compatible and DTS is not correct.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-06 7:54 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 4:02 [PATCH v8 0/3] media: venus: enable venus on qcs615 Renjiang Han
2025-05-30 4:02 ` [PATCH v8 1/3] media: venus: pm_helpers: use opp-table for the frequency Renjiang Han
2025-05-30 20:26 ` Dmitry Baryshkov
2025-06-03 2:31 ` Renjiang Han
2025-05-31 11:11 ` Konrad Dybcio
2025-06-06 7:12 ` Renjiang Han
2025-05-30 4:02 ` [PATCH v8 2/3] arm64: dts: qcom: qcs615: add venus node to devicetree Renjiang Han
2025-05-30 10:51 ` Konrad Dybcio
2025-05-30 4:02 ` [PATCH v8 3/3] arm64: dts: qcom: qcs615-ride: enable venus node to initialize video codec Renjiang Han
2025-05-30 20:31 ` Dmitry Baryshkov
2025-05-31 0:07 ` Renjiang Han
2025-06-02 6:14 ` Dmitry Baryshkov
2025-05-30 12:52 ` [PATCH v8 0/3] media: venus: enable venus on qcs615 Rob Herring (Arm)
2025-05-30 20:27 ` Dmitry Baryshkov
2025-05-31 0:05 ` Renjiang Han
2025-06-02 6:16 ` Dmitry Baryshkov
2025-06-05 11:24 ` Renjiang Han
2025-06-05 11:46 ` Dmitry Baryshkov
2025-06-05 12:13 ` Krzysztof Kozlowski
2025-06-05 12:30 ` Dmitry Baryshkov
2025-06-05 12:33 ` Krzysztof Kozlowski
2025-06-05 12:40 ` Bryan O'Donoghue
2025-06-05 16:02 ` Dmitry Baryshkov
2025-06-05 16:39 ` Bryan O'Donoghue
2025-06-05 16:40 ` Dmitry Baryshkov
2025-06-05 17:12 ` Krzysztof Kozlowski
2025-06-05 17:13 ` Dmitry Baryshkov
2025-06-06 3:52 ` Renjiang Han
2025-06-06 7:51 ` Renjiang Han
2025-06-06 7:54 ` Krzysztof Kozlowski [this message]
2025-06-07 2:08 ` Dmitry Baryshkov
2025-06-05 12:34 ` Bryan O'Donoghue
2025-06-06 12:37 ` Renjiang Han
2025-06-06 12:44 ` Krzysztof Kozlowski
2025-06-06 12:51 ` Renjiang Han
2025-06-06 12:56 ` Krzysztof Kozlowski
2025-06-06 13:32 ` Renjiang Han
2025-06-06 14:53 ` Bryan O'Donoghue
2025-06-06 15:35 ` Vikash Garodia
2025-06-07 2:13 ` Dmitry Baryshkov
2025-06-07 2:31 ` Renjiang Han
2025-06-07 9:16 ` Bryan O'Donoghue
2025-06-07 10:32 ` Dmitry Baryshkov
2025-06-07 9:46 ` Krzysztof Kozlowski
2025-06-11 15:06 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85533e92-43bb-40dd-a8d5-13d19e859616@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=quic_dikshita@quicinc.com \
--cc=quic_renjiang@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).