From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from resqmta-po-12v.sys.comcast.net ([96.114.154.171]:33740 "EHLO resqmta-po-12v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbdGUSFT (ORCPT ); Fri, 21 Jul 2017 14:05:19 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH] dvb_frontend: initialize variable s with FE_NONE instead of 0 To: Colin King , Mauro Carvalho Chehab , Max Kellermann , Ingo Molnar , Markus Elfring , Masahiro Yamada , linux-media@vger.kernel.org References: <20170721160100.22617-1-colin.king@canonical.com> From: Shuah Khan Cc: Shuah Khan , Shuah Khan Message-ID: <85739b36-5d04-a64f-e3d5-b8f84bf9d19a@kernel.org> Date: Fri, 21 Jul 2017 12:05:17 -0600 MIME-Version: 1.0 In-Reply-To: <20170721160100.22617-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: On 07/21/2017 10:01 AM, Colin King wrote: > From: Colin Ian King > > In a previous commit, we added FE_NONE as an unknown fe_status. > Initialize variable s to FE_NONE instead of the more opaque value 0. > > Signed-off-by: Colin Ian King The change looks good to me. Reviewed-by: Shuah Khan I think this patch should be part of a patch series that includes the uAPI Documentation change, uAPI change, and the following patch: [PATCH][V2] dvb_frontend: ensure that inital front end status initialized based on Mauro's review comments. Anyway, I will leave it to Mauro to decide how he wants the patches split and if he is okay with uAPI change. thanks, -- Shuah > --- > drivers/media/dvb-core/dvb_frontend.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c > index 18cc3bbc699c..114994ca0929 100644 > --- a/drivers/media/dvb-core/dvb_frontend.c > +++ b/drivers/media/dvb-core/dvb_frontend.c > @@ -460,7 +460,7 @@ static int dvb_frontend_swzigzag_autotune(struct dvb_frontend *fe, int check_wra > > static void dvb_frontend_swzigzag(struct dvb_frontend *fe) > { > - enum fe_status s = 0; > + enum fe_status s = FE_NONE; > int retval = 0; > struct dvb_frontend_private *fepriv = fe->frontend_priv; > struct dtv_frontend_properties *c = &fe->dtv_property_cache, tmp; >