From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E262017C64 for ; Wed, 3 Apr 2024 06:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712127073; cv=none; b=ockR2b+kIeqllhiGHoHEUEGJ584oSibwMFRC71Kca5nxkzlVHMr0AOxWVaz6duhN7gGBikVwo/XIBkUJDDcSno6l0ZToDBsJaWiXN024AJ5ori5Yj9/pWdCcIWlppoh2/MsFB1zWEkzFJhQlZBEQT48jnj8wnedljkDUHRJB/UU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712127073; c=relaxed/simple; bh=1EeIlIHbNQ3FxngRAaQjhfmr0Jvb27km40uO6N2angI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dir3E5+69qccW7SFhLGotTLMx0Rg6e2Iu+MoprdlJaGokR5/snn8jaeroQykiT6bCUwuvWYbrc6lJNwgwo5CcBuoCU2q+EkC/cHqtJlyQs2igiEws8itCT+mz9u/tU+wczBV8Ws4EqCeQsogsIS50eixyseriv5Z/wtpYXxNsAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=aXsKByG/; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aXsKByG/" Received: from [192.168.88.20] (91-154-34-181.elisa-laajakaista.fi [91.154.34.181]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 979E4674; Wed, 3 Apr 2024 08:50:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712127027; bh=1EeIlIHbNQ3FxngRAaQjhfmr0Jvb27km40uO6N2angI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aXsKByG/rFZ3Mq57MEdlFcw4GEFnyutPzJcVBtCOsEcENnkcF9uXva/p8IMWJzqFc MPoLvNE43rki7hCou5nrzbvYxysyx9xYnNw0czpuQaf0dVAIhvvWV6H7SeJKxoI3Cx LNk9RVAk9si8FZ0abrKyim7kL1+j7pnbfbdhCaPM= Message-ID: <86075433-94d7-422c-bef2-65875faeaedb@ideasonboard.com> Date: Wed, 3 Apr 2024 09:51:01 +0300 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: v4l2-subdev: Fix stream handling for crop API To: Laurent Pinchart , Sakari Ailus Cc: linux-media@vger.kernel.org, Hans Verkuil References: <20240401233725.2401-1-laurent.pinchart@ideasonboard.com> <20240402084407.GC10288@pendragon.ideasonboard.com> <20240402201137.GB32172@pendragon.ideasonboard.com> From: Tomi Valkeinen Content-Language: en-US Autocrypt: addr=tomi.valkeinen@ideasonboard.com; keydata= xsFNBE6ms0cBEACyizowecZqXfMZtnBniOieTuFdErHAUyxVgtmr0f5ZfIi9Z4l+uUN4Zdw2 wCEZjx3o0Z34diXBaMRJ3rAk9yB90UJAnLtb8A97Oq64DskLF81GCYB2P1i0qrG7UjpASgCA Ru0lVvxsWyIwSfoYoLrazbT1wkWRs8YBkkXQFfL7Mn3ZMoGPcpfwYH9O7bV1NslbmyJzRCMO eYV258gjCcwYlrkyIratlHCek4GrwV8Z9NQcjD5iLzrONjfafrWPwj6yn2RlL0mQEwt1lOvn LnI7QRtB3zxA3yB+FLsT1hx0va6xCHpX3QO2gBsyHCyVafFMrg3c/7IIWkDLngJxFgz6DLiA G4ld1QK/jsYqfP2GIMH1mFdjY+iagG4DqOsjip479HCWAptpNxSOCL6z3qxCU8MCz8iNOtZk DYXQWVscM5qgYSn+fmMM2qN+eoWlnCGVURZZLDjg387S2E1jT/dNTOsM/IqQj+ZROUZuRcF7 0RTtuU5q1HnbRNwy+23xeoSGuwmLQ2UsUk7Q5CnrjYfiPo3wHze8avK95JBoSd+WIRmV3uoO rXCoYOIRlDhg9XJTrbnQ3Ot5zOa0Y9c4IpyAlut6mDtxtKXr4+8OzjSVFww7tIwadTK3wDQv Bus4jxHjS6dz1g2ypT65qnHen6mUUH63lhzewqO9peAHJ0SLrQARAQABzTBUb21pIFZhbGtl aW5lbiA8dG9taS52YWxrZWluZW5AaWRlYXNvbmJvYXJkLmNvbT7CwY4EEwEIADgWIQTEOAw+ ll79gQef86f6PaqMvJYe9QUCX/HruAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRD6 PaqMvJYe9WmFD/99NGoD5lBJhlFDHMZvO+Op8vCwnIRZdTsyrtGl72rVh9xRfcSgYPZUvBuT VDxE53mY9HaZyu1eGMccYRBaTLJSfCXl/g317CrMNdY0k40b9YeIX10feiRYEWoDIPQ3tMmA 0nHDygzcnuPiPT68JYZ6tUOvAt7r6OX/litM+m2/E9mtp8xCoWOo/kYO4mOAIoMNvLB8vufi uBB4e/AvAjtny4ScuNV5c5q8MkfNIiOyag9QCiQ/JfoAqzXRjVb4VZG72AKaElwipiKCWEcU R4+Bu5Qbaxj7Cd36M/bI54OrbWWETJkVVSV1i0tghCd6HHyquTdFl7wYcz6cL1hn/6byVnD+ sR3BLvSBHYp8WSwv0TCuf6tLiNgHAO1hWiQ1pOoXyMEsxZlgPXT+wb4dbNVunckwqFjGxRbl Rz7apFT/ZRwbazEzEzNyrBOfB55xdipG/2+SmFn0oMFqFOBEszXLQVslh64lI0CMJm2OYYe3 PxHqYaztyeXsx13Bfnq9+bUynAQ4uW1P5DJ3OIRZWKmbQd/Me3Fq6TU57LsvwRgE0Le9PFQs dcP2071rMTpqTUteEgODJS4VDf4lXJfY91u32BJkiqM7/62Cqatcz5UWWHq5xeF03MIUTqdE qHWk3RJEoWHWQRzQfcx6Fn2fDAUKhAddvoopfcjAHfpAWJ+ENc7BTQROprNHARAAx0aat8GU hsusCLc4MIxOQwidecCTRc9Dz/7U2goUwhw2O5j9TPqLtp57VITmHILnvZf6q3QAho2QMQyE DDvHubrdtEoqaaSKxKkFie1uhWNNvXPhwkKLYieyL9m2JdU+b88HaDnpzdyTTR4uH7wk0bBa KbTSgIFDDe5lXInypewPO30TmYNkFSexnnM3n1PBCqiJXsJahE4ZQ+WnV5FbPUj8T2zXS2xk 0LZ0+DwKmZ0ZDovvdEWRWrz3UzJ8DLHb7blPpGhmqj3ANXQXC7mb9qJ6J/VSl61GbxIO2Dwb xPNkHk8fwnxlUBCOyBti/uD2uSTgKHNdabhVm2dgFNVuS1y3bBHbI/qjC3J7rWE0WiaHWEqy UVPk8rsph4rqITsj2RiY70vEW0SKePrChvET7D8P1UPqmveBNNtSS7In+DdZ5kUqLV7rJnM9 /4cwy+uZUt8cuCZlcA5u8IsBCNJudxEqBG10GHg1B6h1RZIz9Q9XfiBdaqa5+CjyFs8ua01c 9HmyfkuhXG2OLjfQuK+Ygd56mV3lq0aFdwbaX16DG22c6flkkBSjyWXYepFtHz9KsBS0DaZb 4IkLmZwEXpZcIOQjQ71fqlpiXkXSIaQ6YMEs8WjBbpP81h7QxWIfWtp+VnwNGc6nq5IQDESH mvQcsFS7d3eGVI6eyjCFdcAO8eMAEQEAAcLBXwQYAQIACQUCTqazRwIbDAAKCRD6PaqMvJYe 9fA7EACS6exUedsBKmt4pT7nqXBcRsqm6YzT6DeCM8PWMTeaVGHiR4TnNFiT3otD5UpYQI7S suYxoTdHrrrBzdlKe5rUWpzoZkVK6p0s9OIvGzLT0lrb0HC9iNDWT3JgpYDnk4Z2mFi6tTbq xKMtpVFRA6FjviGDRsfkfoURZI51nf2RSAk/A8BEDDZ7lgJHskYoklSpwyrXhkp9FHGMaYII m9EKuUTX9JPDG2FTthCBrdsgWYPdJQvM+zscq09vFMQ9Fykbx5N8z/oFEUy3ACyPqW2oyfvU CH5WDpWBG0s5BALp1gBJPytIAd/pY/5ZdNoi0Cx3+Z7jaBFEyYJdWy1hGddpkgnMjyOfLI7B CFrdecTZbR5upjNSDvQ7RG85SnpYJTIin+SAUazAeA2nS6gTZzumgtdw8XmVXZwdBfF+ICof 92UkbYcYNbzWO/GHgsNT1WnM4sa9lwCSWH8Fw1o/3bX1VVPEsnESOfxkNdu+gAF5S6+I6n3a ueeIlwJl5CpT5l8RpoZXEOVtXYn8zzOJ7oGZYINRV9Pf8qKGLf3Dft7zKBP832I3PQjeok7F yjt+9S+KgSFSHP3Pa4E7lsSdWhSlHYNdG/czhoUkSCN09C0rEK93wxACx3vtxPLjXu6RptBw 3dRq7n+mQChEB1am0BueV1JZaBboIL0AGlSJkm23kw== In-Reply-To: <20240402201137.GB32172@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/04/2024 23:11, Laurent Pinchart wrote: > On Tue, Apr 02, 2024 at 03:23:03PM +0000, Sakari Ailus wrote: >> On Tue, Apr 02, 2024 at 12:11:30PM +0300, Tomi Valkeinen wrote: >>> On 02/04/2024 11:46, Sakari Ailus wrote: >>>> On Tue, Apr 02, 2024 at 11:44:07AM +0300, Laurent Pinchart wrote: >>>>> On Tue, Apr 02, 2024 at 08:20:22AM +0000, Sakari Ailus wrote: >>>>>> Moi, >>>>>> >>>>>> On Tue, Apr 02, 2024 at 02:37:25AM +0300, Laurent Pinchart wrote: >>>>>>> When support for streams was added to the V4L2 subdev API, the >>>>>>> v4l2_subdev_crop structure was extended with a stream field, but the >>>>>>> field was not handled in the core code that translates the >>>>>>> VIDIOC_SUBDEV_[GS]_CROP ioctls to the selection API. Fix it. >>>>>> >>>>>> The field is indeed in the UAPI headers. But do we want to support the CROP >>>>>> IOCTL for streams? Shouldn't the callers be using the [GS]_SELECTION >>>>>> instead? >>>>> >>>>> They should, but if the field is there, we should support it :-) The >>>>> alternative is to remove it. It will cause failures in v4l2-compliance >>>>> that we'll need to handle though. >>>> >>>> I'd prefer to stick to selections here, this is new functionality so >>>> [GS]_CROP support isn't required. I don't have a strong opinion on the >>>> matter though. >>> >>> Maybe it's easier to just support the stream field, instead of making >>> [GS]_CROP the odd case which looks like it should support streams, but then >>> doesn't... >> >> It's an old IOCTL already replaced by the [GS]_SELECTION. I mainly write >> kernel space software but overall I think it's better if we can provide a >> single API for controlling cropping instead of two with similar >> functionality, of which the user then should choose from. >> >> It should be also documented in this context if we choose support >> [GS]_CROP. >> >> So I believe we have less work to do and have a better result if we just >> drop the stream field there. :-) > > I tend to agree, even if that's only a slight preference. Tomi, if > you're fine with this, I'll update the patch. I'm fine with it. So we now should move the 'stream' field back to reserved, and add documentation saying that [GS]_CROP works differently than the other ioctls? Tomi