From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: "jackson.lee" <jackson.lee@chipsnmedia.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"bob.beckett@collabora.com" <bob.beckett@collabora.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lafley.kim" <lafley.kim@chipsnmedia.com>,
"b-brnich@ti.com" <b-brnich@ti.com>,
"hverkuil@xs4all.nl" <hverkuil@xs4all.nl>,
Nas Chung <nas.chung@chipsnmedia.com>
Subject: Re: [PATCH v0 1/3] media: chips-media: wave5: Add Support for Background Detection
Date: Fri, 20 Mar 2026 13:00:12 -0400 [thread overview]
Message-ID: <86a603a4bebd12ac854d201627d47d0eedacebe0.camel@collabora.com> (raw)
In-Reply-To: <PU4P216MB1149B5B5B7BABB4176BF5C87ED4CA@PU4P216MB1149.KORP216.PROD.OUTLOOK.COM>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
Le vendredi 20 mars 2026 à 01:34 +0000, jackson.lee a écrit :
> Hi Nicolas
> > >
[...]
> > >
> >
> > The hard question, last parameter here is def, so I read this is disabled
> > by default. What's the side effect of having this enabled by default ? Did
> > you already considered that option ?
> >
>
> Background detection is disabled by default because not all use cases benefit
> from this feature.
> When enabled, detected background regions are encoded with fewer bits or skip
> mode,
> which reduces bitrate but may not be desirable in every scenario.
> We chose to let the user explicitly opt-in rather than enable it by default.
Ack
>
> Thanks for your review.
> Jackson
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-03-20 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 5:32 [PATCH v0 0/3] Add encoder features Jackson.lee
2026-03-19 5:32 ` [PATCH v0 1/3] media: chips-media: wave5: Add Support for Background Detection Jackson.lee
2026-03-19 21:17 ` Nicolas Dufresne
2026-03-20 1:34 ` jackson.lee
2026-03-20 17:00 ` Nicolas Dufresne [this message]
2026-03-20 6:37 ` jackson.lee
2026-03-20 13:25 ` Nicolas Dufresne
2026-03-19 5:32 ` [PATCH v0 2/3] media: chips-media: wave5: Support CBP profile Jackson.lee
2026-03-19 12:32 ` Nicolas Dufresne
2026-03-20 1:23 ` jackson.lee
2026-03-23 17:06 ` Brandon Brnich
2026-03-24 0:32 ` jackson.lee
2026-03-19 5:32 ` [PATCH v0 3/3] media: chips-media: wave5: Add Support for Packed YUV422 Formats Jackson.lee
2026-03-19 21:18 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a603a4bebd12ac854d201627d47d0eedacebe0.camel@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=b-brnich@ti.com \
--cc=bob.beckett@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=hverkuil@xs4all.nl \
--cc=jackson.lee@chipsnmedia.com \
--cc=lafley.kim@chipsnmedia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nas.chung@chipsnmedia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox