From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Enrico Scholz <enrico.scholz@sigma-chemnitz.de>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: mt9m111: fix fw-node refactoring
Date: Mon, 24 Jun 2019 22:03:12 +0200 [thread overview]
Message-ID: <8736jyycn3.fsf@belgarion.home> (raw)
In-Reply-To: <20190620123509.7pssbcqjqcnh3kmc@valkosipuli.retiisi.org.uk> (Sakari Ailus's message of "Thu, 20 Jun 2019 15:35:09 +0300")
Sakari Ailus <sakari.ailus@iki.fi> writes:
> On Thu, Jun 20, 2019 at 01:17:17PM +0300, Sakari Ailus wrote:
>> diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
>> index bd3a51c3b081..9761a6105407 100644
>> --- a/drivers/media/i2c/mt9m111.c
>> +++ b/drivers/media/i2c/mt9m111.c
>> @@ -1263,9 +1263,11 @@ static int mt9m111_probe(struct i2c_client *client,
>> if (!mt9m111)
>> return -ENOMEM;
>>
>> - ret = mt9m111_probe_fw(client, mt9m111);
>> - if (ret)
>> - return ret;
>> + if (dev_fwnode(client->dev)) {
>
> &client->dev
>
>> + ret = mt9m111_probe_fw(client, mt9m111);
>> + if (ret)
>> + return ret;
>> + }
>>
>> mt9m111->clk = v4l2_clk_get(&client->dev, "mclk");
>> if (IS_ERR(mt9m111->clk))
Sure, you can take the patch as yours, or sign off my modified patch, whatever
pleases you.
Cheers.
--
Robert
prev parent reply other threads:[~2019-06-24 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 20:01 [PATCH] media: mt9m111: fix fw-node refactoring Robert Jarzmik
2019-06-20 10:17 ` Sakari Ailus
2019-06-20 12:35 ` Sakari Ailus
2019-06-24 20:03 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736jyycn3.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox