From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "video4linux-list@redhat.com" <video4linux-list@redhat.com>
Subject: Re: About CITOR register value for pxa_camera
Date: Sun, 30 Nov 2008 23:42:48 +0100 [thread overview]
Message-ID: <873ah8n8d3.fsf@free.fr> (raw)
In-Reply-To: <Pine.LNX.4.64.0811290229070.7032@axis700.grange> (Guennadi Liakhovetski's message of "Sat\, 29 Nov 2008 02\:42\:50 +0100 \(CET\)")
Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
> I finally got round to trying this...
>
> Please, have a look at this patch. I decided against another function call
> for a number of reasons: first, if the host calls into the camera to ask
> whether the frequency has changed, it is not easy to recognise, whether it
> changed _now_, if you let camera notify the host about frequency change
> this breaks the hierarchy. Second, you don't know how many more similar
> parameters will have to be communicated between the camera and the host.
> So, I decided to add an extensible sense struct.
>
> Only compile tested so far, will run-test later, maybe tomorrow (actually,
> already today). Comments welcome, tests even more so:-)
The first test crashes in the pxa_camera_probe() for me, something like :
[ 247.554669] [<c014f2f8>] (dev_driver_string+0x0/0x48) from [<bf01eac8>] (pxa_camera_probe+0x2c8/0x424 [pxa_camera])
[ 247.564907] [<bf01e800>] (pxa_camera_probe+0x0/0x424 [pxa_camera]) from [<c01538fc>] (platform_drv_probe+0x20/0x24)
[ 247.575129] [<c01538dc>] (platform_drv_probe+0x0/0x24) from [<c0152a3c>] (driver_probe_device+0xac/0x1b0)
[ 247.585308] [<c0152990>] (driver_probe_device+0x0/0x1b0) from [<c0152bd0>] (__driver_attach+0x90/0x94)
I'll take some time tomorrow, to review and test.
> Patch below. Loosely based on top of our current format-negotiation
> stack...
Applies nicely, thanks.
--
Robert
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-11-30 22:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 12:01 About CITOR register value for pxa_camera fpantaleao
2008-11-29 1:42 ` Guennadi Liakhovetski
2008-11-30 22:42 ` Robert Jarzmik [this message]
2008-11-30 23:59 ` Guennadi Liakhovetski
2008-12-01 9:41 ` [PATCH 1/2] soc-camera: add camera sense data Guennadi Liakhovetski
2008-12-01 9:41 ` [PATCH 2/2] pxa-camera: setup the FIFO inactivity time-out register Guennadi Liakhovetski
2008-12-01 15:14 ` About CITOR register value for pxa_camera Guennadi Liakhovetski
2008-12-01 21:13 ` Robert Jarzmik
-- strict thread matches above, loose matches on Subject: below --
2008-11-07 6:22 fpantaleao
2008-11-07 7:58 ` Guennadi Liakhovetski
2008-11-06 5:26 fpantaleao
2008-11-06 23:57 ` Guennadi Liakhovetski
2008-11-05 14:14 fpantaleao
2008-11-05 19:31 ` Guennadi Liakhovetski
2008-10-31 15:05 fpantaleao
2008-10-31 18:45 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873ah8n8d3.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=g.liakhovetski@gmx.de \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox