From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAUMh4II003477 for ; Sun, 30 Nov 2008 17:43:04 -0500 Received: from smtp3-g19.free.fr (smtp3-g19.free.fr [212.27.42.29]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id mAUMgo0Y008439 for ; Sun, 30 Nov 2008 17:42:50 -0500 To: Guennadi Liakhovetski References: <20081107130136.fkdeaklvs40ocsws@webmail.hebergement.com> From: Robert Jarzmik Date: Sun, 30 Nov 2008 23:42:48 +0100 In-Reply-To: (Guennadi Liakhovetski's message of "Sat\, 29 Nov 2008 02\:42\:50 +0100 \(CET\)") Message-ID: <873ah8n8d3.fsf@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "video4linux-list@redhat.com" Subject: Re: About CITOR register value for pxa_camera List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: Guennadi Liakhovetski writes: > I finally got round to trying this... > > Please, have a look at this patch. I decided against another function call > for a number of reasons: first, if the host calls into the camera to ask > whether the frequency has changed, it is not easy to recognise, whether it > changed _now_, if you let camera notify the host about frequency change > this breaks the hierarchy. Second, you don't know how many more similar > parameters will have to be communicated between the camera and the host. > So, I decided to add an extensible sense struct. > > Only compile tested so far, will run-test later, maybe tomorrow (actually, > already today). Comments welcome, tests even more so:-) The first test crashes in the pxa_camera_probe() for me, something like : [ 247.554669] [] (dev_driver_string+0x0/0x48) from [] (pxa_camera_probe+0x2c8/0x424 [pxa_camera]) [ 247.564907] [] (pxa_camera_probe+0x0/0x424 [pxa_camera]) from [] (platform_drv_probe+0x20/0x24) [ 247.575129] [] (platform_drv_probe+0x0/0x24) from [] (driver_probe_device+0xac/0x1b0) [ 247.585308] [] (driver_probe_device+0x0/0x1b0) from [] (__driver_attach+0x90/0x94) I'll take some time tomorrow, to review and test. > Patch below. Loosely based on top of our current format-negotiation > stack... Applies nicely, thanks. -- Robert -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list