From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.tkos.co.il (golan.tkos.co.il [84.110.109.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA99716C69C for ; Thu, 18 Apr 2024 15:44:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=84.110.109.230 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713455057; cv=none; b=lNXUVn7g1fxoziLDOooPaCckFnA6b6sjEnqhbAtvxvGbIR14gIOqLW1iNkwMqpKSlC7GB8HXQA9M6dHoWLPOH1KVr6dinRRcFhuhNQ4BqELzXtYLDY5J/YBCWsCGqJ5+6lWcvvs1yZOO4FfB67ydEnwrt25pWn1VEWuAFTn0NyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713455057; c=relaxed/simple; bh=iIKKAiCnRrAgDIHZSb5hVhvQsqE83aNLWEDnlLR6DHA=; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID: MIME-Version:Content-Type; b=jliTNPzr9+KPf/qqx38SB9skduFMruU9bu+XAccoz5AywLor5gBp7U31FLy8BKi7pmmoqBfs/SjQslzg89DJQXisTI9dodg8mnFZQ+pX7o33gvKJATRQwkZ3jFtnSvGpVfBI1gx7aTDQTUnEXo1nISKozcUCR/FAODgzXieUbC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il; spf=pass smtp.mailfrom=tkos.co.il; dkim=pass (2048-bit key) header.d=tkos.co.il header.i=@tkos.co.il header.b=lBOF4Nmx; arc=none smtp.client-ip=84.110.109.230 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tkos.co.il Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tkos.co.il header.i=@tkos.co.il header.b="lBOF4Nmx" Received: from localhost (unknown [10.0.8.4]) by mail.tkos.co.il (Postfix) with ESMTP id BED6544060F; Thu, 18 Apr 2024 18:43:58 +0300 (IDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1713455038; bh=iIKKAiCnRrAgDIHZSb5hVhvQsqE83aNLWEDnlLR6DHA=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=lBOF4Nmxa2i74GupirMIm7BEyf+CY3t4N2S9rrDdHsn+kngATbdgVLjeDCXu7S5Xf tmYHqi7okN2cfnBzUz0lTOLDTJUtlIcrtU/B0Em24JA30kNQ6ix5blwj3vfVB18nJ6 chYI6pVDffiUEYenwDh4ChfDAgB+FFByfZPpeHV0+Y7Fmmla0893W7DCQK4ZpVpGMQ TBTC9rUViLMXfKVRQGrfILZNh5zYM81IGn/t2qsdFVhStC2jbaTxJMRdh09VSrdMqD QTi5MmoLVglFh5yjzYYy02U5g8jUx1C3qswHuLc3CgEagxmIBEjwiJlgswUtiN0ijc fmILEoXpX2NCA== References: <505484b83fedebce3c65b10b076b34df075074b6.1713329988.git.baruch@tkos.co.il> User-agent: mu4e 1.10.8; emacs 29.2 From: Baruch Siach To: Christian =?utf-8?Q?K=C3=B6nig?= Cc: Sumit Semwal , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v2] doc: dma-buf: fix grammar typo Date: Thu, 18 Apr 2024 18:23:42 +0300 In-reply-to: Message-ID: <874jbyad6j.fsf@tarshish> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Christian, On Thu, Apr 18 2024, Christian K=C3=B6nig wrote: > Well checkpatch.pl still complained: > > ERROR: trailing whitespace > #157: FILE: Documentation/driver-api/dma-buf.rst:80: > +=C2=A0 If llseek on dma-buf FDs isn't supported the kernel will report -= ESPIPE for > all^M$ > > That actually looks like you used a Windows line ending. Interesting. I can't reproduce that here: $ hexdump -C 0001-doc-dma-buf-fix-grammar-typo.patch ... 00000490 6f 72 74 20 2d 45 53 50 49 50 45 20 66 6f 72 20 |ort -ESPIPE fo= r | 000004a0 61 6c 6c 0a 20 20 20 63 61 73 65 73 2e 20 55 73 |all. cases. = Us| Only a single Unix style EOL character (0x0a) is shown. Same if I dump the email from the archive: curl https://lore.kernel.org/all/505484b83fedebce3c65b10b076b34df075074b6.1= 713329988.git.baruch@tkos.co.il/raw |hexdump -C ... 00001010 6c 20 72 65 70 6f 72 74 20 2d 45 53 50 49 50 45 |l report -ESPI= PE| 00001020 20 66 6f 72 20 61 6c 6c 0a 20 20 20 63 61 73 65 | for all. ca= se| Do you get the same blob hash (29abf1eebf9f) when running git hash-object -t blob Documentation/driver-api/dma-buf.rst on the resulting file before you fixed it? > I fixed it up and pushed the patch, but please take a bit more care next = time. Thanks. I'm curious to know what kind of care I should take. baruch > Am 17.04.24 um 06:59 schrieb Baruch Siach: >> Use 'supported' instead of 'support'. 'support' makes no sense in this >> context. >> >> Signed-off-by: Baruch Siach >> --- >> v2: Add commit log message (Christian K=C3=B6nig) >> --- >> Documentation/driver-api/dma-buf.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver= -api/dma-buf.rst >> index 0c153d79ccc4..29abf1eebf9f 100644 >> --- a/Documentation/driver-api/dma-buf.rst >> +++ b/Documentation/driver-api/dma-buf.rst >> @@ -77,7 +77,7 @@ consider though: >> the usual size discover pattern size =3D SEEK_END(0); SEEK_SET(0). E= very other >> llseek operation will report -EINVAL. >> - If llseek on dma-buf FDs isn't support the kernel will report -ESPI= PE >> for all >> + If llseek on dma-buf FDs isn't supported the kernel will report -ESPI= PE for all >> cases. Userspace can use this to detect support for discovering the = dma-buf >> size using llseek. >>=20=20=20 --=20 ~. .~ Tk Open Systems =3D}------------------------------------------------ooO--U--Ooo------------= {=3D - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -