From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAAJFTEx015530 for ; Mon, 10 Nov 2008 14:15:29 -0500 Received: from smtp1-g19.free.fr (smtp1-g19.free.fr [212.27.42.27]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id mAAJFGfM017510 for ; Mon, 10 Nov 2008 14:15:16 -0500 To: Guennadi Liakhovetski References: <30353c3d0811101009u195fb42du346ff3e0fb559b19@mail.gmail.com> From: Robert Jarzmik Date: Mon, 10 Nov 2008 20:15:14 +0100 In-Reply-To: (Guennadi Liakhovetski's message of "Mon\, 10 Nov 2008 19\:43\:44 +0100 \(CET\)") Message-ID: <874p2f9yv1.fsf@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: video4linux-list@redhat.com, David Ellingsworth Subject: Re: [PATCH 5/5] pxa-camera: framework to handle camera-native and synthesized formats List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: Guennadi Liakhovetski writes: > Indeed, a good idea, thanks, only I would do this like > > return !!(pcdev->platform_flags & PXA_CAMERA_DATAWIDTH_8); You're using it 2 times, and with a if (!depth_supported()), that's overkill. Wouldn't it be better for that function to return 0 for false, and "not 0" for true ? That's what was done for gpio API (check gpio_get_value()) ... I would definitely drop the purely boolean part, I don't think it brings anything here (the function name is already very clear, isn't it ? :)) JM2P. -- Robert -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list