public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: video4linux-list@redhat.com,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH, RFC] mt9m111: Fix YUYV format for pxa-camera
Date: Wed, 29 Oct 2008 18:16:34 +0100	[thread overview]
Message-ID: <874p2vs4nh.fsf@free.fr> (raw)
In-Reply-To: <20081029123446.540dcd2e.ospite@studenti.unina.it> (Antonio Ospite's message of "Wed\, 29 Oct 2008 12\:34\:46 +0100")

Antonio Ospite <ospite@studenti.unina.it> writes:

> Hi,
>
> I'd like to discuss this change to mt9m111, but I am not sure if the
> first hunk of the following patch is a proper fix for the problem I had:
> when using YUYV the output buffer has to be WIDTH*HEIGHT*2,
> and not WIDTH*HEIGHT as it is now using 8bit YUYV format.
> Maybe the proper fix belongs to pxa-camera.c?

No, your patch is the correct way of doing it.  Please resubmit the same patch
with your signoff, and Guennadi CCed which will give me time to make 1 test for
security, and I'll add my Acked-by.

You can safely remove the "RFC" part, it is indeed a fix.

Cheers.

--
Robert

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

      reply	other threads:[~2008-10-29 17:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 11:34 [PATCH, RFC] mt9m111: Fix YUYV format for pxa-camera Antonio Ospite
2008-10-29 17:16 ` Robert Jarzmik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874p2vs4nh.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=g.liakhovetski@gmx.de \
    --cc=ospite@studenti.unina.it \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox