Re: [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc)

Re: [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc)

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

> diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
> --- a/drivers/video/intelfb/intelfbdrv.c
> +++ b/drivers/video/intelfb/intelfbdrv.c
> @@ -230,16 +230,16 @@ MODULE_DESCRIPTION("Framebuffer driver f
>  MODULE_LICENSE("Dual BSD/GPL");
>  MODULE_DEVICE_TABLE(pci, intelfb_pci_table);
>  
> -static int accel        = 1;
> +static bool accel       = 1;
>  static int vram         = 4;
> -static int hwcursor     = 0;
> -static int mtrr         = 1;
> -static int fixed        = 0;
> -static int noinit       = 0;
> -static int noregister   = 0;
> -static int probeonly    = 0;
> -static int idonly       = 0;
> -static int bailearly    = 0;
> +static bool hwcursor    = 0;
> +static bool mtrr        = 1;
> +static bool fixed       = 0;
> +static bool noinit      = 0;
> +static bool noregister  = 0;
> +static bool probeonly   = 0;
> +static bool idonly      = 0;
> +static bool bailearly   = 0;

bailearly should be an int here.  It's part of some ugly debug code
where a value of 3 means bailout at point 3.  Maybe we should just
remove it instead...

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc)

[Rusty Russell]

On Tue, 3 Jan 2012 15:44:20 +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
Non-text part: multipart/signed
> > diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
> > --- a/drivers/video/intelfb/intelfbdrv.c
> > +++ b/drivers/video/intelfb/intelfbdrv.c
> > @@ -230,16 +230,16 @@ MODULE_DESCRIPTION("Framebuffer driver f
> >  MODULE_LICENSE("Dual BSD/GPL");
> >  MODULE_DEVICE_TABLE(pci, intelfb_pci_table);
> >  
> > -static int accel        = 1;
> > +static bool accel       = 1;
> >  static int vram         = 4;
> > -static int hwcursor     = 0;
> > -static int mtrr         = 1;
> > -static int fixed        = 0;
> > -static int noinit       = 0;
> > -static int noregister   = 0;
> > -static int probeonly    = 0;
> > -static int idonly       = 0;
> > -static int bailearly    = 0;
> > +static bool hwcursor    = 0;
> > +static bool mtrr        = 1;
> > +static bool fixed       = 0;
> > +static bool noinit      = 0;
> > +static bool noregister  = 0;
> > +static bool probeonly   = 0;
> > +static bool idonly      = 0;
> > +static bool bailearly   = 0;
> 
> bailearly should be an int here.  It's part of some ugly debug code
> where a value of 3 means bailout at point 3.  Maybe we should just
> remove it instead...

Yeah, it never worked, since you could only ever set it to 0 or 1:

        module_param(bailearly, bool, 0);

On Tue, 3 Jan 2012 15:58:13 +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Thu, Dec 15, 2011 at 01:48:51PM +1030, Rusty Russell wrote:
> > diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c
> > --- a/drivers/block/paride/pcd.c
> > +++ b/drivers/block/paride/pcd.c
...
> > -static int verbose = 0;
> > +static bool verbose = 0;
> 
> This should be int.  Verbose can be set to 2 for extra verbosity.

Again, I haven't made it more broken than it is already:

        module_param(verbose, bool, 0644);

I've split these two off into separate fixes.  Thanks!

> Btw, these patches that touch a ton of drivers are the wrong idea.
> If you ack any part of it, then get_maintainer.pl CCs you on every
> single kernel patch until eventually you get old and die.

I didn't know that; get_maintainer.pl usually produces too much spew for
me anyway.  It could use some smarts.

Cheers,
Rusty.