From: Kevin Hilman <khilman@ti.com>
To: "Ramirez Luna\, Omar" <omar.ramirez@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Benoit Cousson <b-cousson@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Ohad Ben-Cohen <ohad@wizery.com>, lo <linux-omap@vger.kernel.org>,
lak <linux-arm-kernel@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
lm <linux-media@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] OMAP4: hwmod data: add mmu hwmod for ipu and dsp
Date: Tue, 08 Nov 2011 09:41:39 -0800 [thread overview]
Message-ID: <8762iuqzos.fsf@ti.com> (raw)
In-Reply-To: <CAB-zwWgd5U+8UNFe_rLY99VpiaHhTqscwYNF+SmuRTyDi+h3+A@mail.gmail.com> (Ramirez Luna's message of "Tue, 8 Nov 2011 10:21:08 -0600")
"Ramirez Luna, Omar" <omar.ramirez@ti.com> writes:
> Hi,
>
> On Fri, Nov 4, 2011 at 6:23 PM, Kevin Hilman <khilman@ti.com> wrote:
>>> + .flags = HWMOD_INIT_NO_RESET,
>>
>> Why is this needed?
> ...
>>> + .flags = HWMOD_INIT_NO_RESET,
>>
>> And this?
>
> I have this because the hwmod complains about a failure in hard reset,
> even though the reset deassert does complete after the clock is
> enabled. Later on, hwmod will warn again because of a wrong state when
> enabling, I believe because of the failure on _setup but didn't dig
> into it yet.
Please dig deeper into the reset failure.
We don't merge HWMOD_INIT_NO_RESET changes without a very good reason
(that is also well described in the changelog.)
Thanks,
Kevin
next prev parent reply other threads:[~2011-11-08 17:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 22:15 [PATCH v3 0/4] OMAP: iommu: hwmod support and runtime PM Omar Ramirez Luna
2011-11-01 22:15 ` [PATCH v3 1/4] OMAP3: hwmod data: add mmu data for iva and isp Omar Ramirez Luna
2011-11-01 22:15 ` [PATCH v3 2/4] OMAP4: hwmod data: add mmu hwmod for ipu and dsp Omar Ramirez Luna
2011-11-04 23:23 ` Kevin Hilman
2011-11-08 16:21 ` Ramirez Luna, Omar
2011-11-08 17:41 ` Kevin Hilman [this message]
2011-11-01 22:15 ` [PATCH v3 3/4] OMAP3/4: iommu: migrate to hwmod framework Omar Ramirez Luna
2011-11-01 22:15 ` [PATCH v3 4/4] OMAP3/4: iommu: adapt to runtime pm Omar Ramirez Luna
2011-11-02 10:16 ` MyungJoo Ham
2011-11-02 15:22 ` Ramirez Luna, Omar
2011-11-02 15:21 ` Russell King - ARM Linux
2011-11-02 15:24 ` Ramirez Luna, Omar
2011-11-04 23:27 ` Kevin Hilman
2011-11-07 18:21 ` Ramirez Luna, Omar
2011-11-02 14:56 ` [PATCH v3 0/4] OMAP: iommu: hwmod support and runtime PM Ramirez Luna, Omar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762iuqzos.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ohad@wizery.com \
--cc=omar.ramirez@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox