From: "Bjørn Mork" <bjorn@mork.no>
To: linux-media@vger.kernel.org
Subject: Re: [PATCH 03/16] ngene: Firmware 18 support
Date: Mon, 10 Jan 2011 15:00:18 +0100 [thread overview]
Message-ID: <8762twyi31.fsf@nemi.mork.no> (raw)
In-Reply-To: 1294652184-12843-4-git-send-email-o.endriss@gmx.de
Oliver Endriss <o.endriss@gmx.de> writes:
> + case 18:
> + size = 0;
> + fw_name = "ngene_18.fw";
> + break;
> }
>
> if (request_firmware(&fw, fw_name, &dev->pci_dev->dev) < 0) {
> @@ -1266,6 +1270,8 @@ static int ngene_load_firm(struct ngene *dev)
> ": Copy %s to your hotplug directory!\n", fw_name);
> return -1;
> }
> + if (size == 0)
> + size = fw->size;
> if (size != fw->size) {
> printk(KERN_ERR DEVICE_NAME
> ": Firmware %s has invalid size!", fw_name);
Just a stupid question: Why remove the size verification for version 18
while keeping it for the other firmware revisions?
Bjørn
next prev parent reply other threads:[~2011-01-10 14:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1294652184-12843-1-git-send-email-o.endriss@gmx.de>
2011-01-10 9:36 ` [PATCH 14/16] stv090x: Fix losing lock in dual DVB-S2 mode Oliver Endriss
[not found] ` <1294652184-12843-4-git-send-email-o.endriss@gmx.de>
2011-01-10 14:00 ` Bjørn Mork [this message]
2011-01-10 17:12 ` [PATCH 03/16] ngene: Firmware 18 support Oliver Endriss
[not found] ` <1294652184-12843-8-git-send-email-o.endriss@gmx.de>
2011-01-10 14:05 ` [PATCH 07/16] ngene: CXD2099AR Common Interface driver Andreas Oberritter
2011-01-10 17:20 ` Oliver Endriss
2011-01-11 1:32 ` Interconnection of different DVB adapters (was: Re: [PATCH 07/16] ngene: CXD2099AR Common Interface driver) Andreas Oberritter
2011-01-11 2:14 ` Oliver Endriss
2011-01-17 16:31 ` [PATCH 07/16] ngene: CXD2099AR Common Interface driver Mauro Carvalho Chehab
2011-01-18 9:13 ` Oliver Endriss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762twyi31.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox