From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF11C433DF for ; Mon, 15 Jun 2020 10:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB0AA2068E for ; Mon, 15 Jun 2020 10:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729381AbgFOKfL (ORCPT ); Mon, 15 Jun 2020 06:35:11 -0400 Received: from smtp12.smtpout.orange.fr ([80.12.242.134]:49482 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728773AbgFOKfK (ORCPT ); Mon, 15 Jun 2020 06:35:10 -0400 Received: from belgarion ([86.210.245.36]) by mwinf5d23 with ME id rNb62200B0nqnCN03Nb6kp; Mon, 15 Jun 2020 12:35:07 +0200 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 15 Jun 2020 12:35:07 +0200 X-ME-IP: 86.210.245.36 From: Robert Jarzmik To: Dan Carpenter Cc: Mauro Carvalho Chehab , Hans Verkuil , Chuhong Yuan , Peter Ujfalusi , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] media: pxa_camera: remove an impossible condition References: <20200610172615.GD90634@mwanda> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 15 Jun 2020 12:35:05 +0200 In-Reply-To: <20200610172615.GD90634@mwanda> (Dan Carpenter's message of "Wed, 10 Jun 2020 20:26:15 +0300") Message-ID: <877dw8borq.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Dan Carpenter writes: > It's not possible for "pcdev->mclk" to be zero because we check for > that earlier and set it to 20000000 in that situation. If it were > possible, that would be a problem because it could have lead to an Oops > in the error handling when we call v4l2_clk_unregister(pcdev->mclk_clk); > > Signed-off-by: Dan Carpenter Acked-by: Robert Jarzmik Cheers. -- Robert