From: Chris Ball <cjb@laptop.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media <linux-media@vger.kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] marvell-cam: fix an ARM build error
Date: Thu, 26 Apr 2012 16:13:37 -0400 [thread overview]
Message-ID: <878vhi9rpq.fsf@laptop.org> (raw)
In-Reply-To: <20120420102250.1389bca8@lwn.net> (Jonathan Corbet's message of "Fri, 20 Apr 2012 10:22:50 -0600")
Hi,
On Fri, Apr 20 2012, Jonathan Corbet wrote:
> One of the OLPC changes lost a little in its translation to mainline,
> leading to build errors on the ARM architecture. Remove the offending
> line, and all will be well.
>
> Reported-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: stable@vger.kernel.org
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
>
> diff --git a/drivers/media/video/marvell-ccic/mmp-driver.c b/drivers/media/video/marvell-ccic/mmp-driver.c
> index d235523..c4c17fe 100644
> --- a/drivers/media/video/marvell-ccic/mmp-driver.c
> +++ b/drivers/media/video/marvell-ccic/mmp-driver.c
> @@ -181,7 +181,6 @@ static int mmpcam_probe(struct platform_device *pdev)
> INIT_LIST_HEAD(&cam->devlist);
>
> mcam = &cam->mcam;
> - mcam->platform = MHP_Armada610;
> mcam->plat_power_up = mmpcam_power_up;
> mcam->plat_power_down = mmpcam_power_down;
> mcam->dev = &pdev->dev;
Tested-by: Chris Ball <cjb@laptop.org>
Thanks!
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-04-26 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 16:22 [PATCH] marvell-cam: fix an ARM build error Jonathan Corbet
2012-04-26 20:13 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vhi9rpq.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=linux-media@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).