public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Hans Verkuil <hverkuil@xs4all.nl>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Muralidharan Karicheri <m-karicheri2@ti.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Paulius Zaleckas <paulius.zaleckas@teltonika.lt>,
	Darius Augulis <augulis.darius@gmail.com>
Subject: Re: [PATCH] adding support for setting bus parameters in sub device
Date: Sun, 14 Jun 2009 21:08:12 +0200	[thread overview]
Message-ID: <87ab4a7hwj.fsf@free.fr> (raw)
In-Reply-To: Pine.LNX.4.64.0906141719510.4412@axis700.grange

Let's begin the maintainers party.

> A board designer knows what the host supports, knows what the sensor 
> supports, and knows if he added any inverters on the board, and based on 
> all that information he can just setup these parameters for the sensor 
> chip. Settings that are fixed on the sensor chip he can just ignore, he 
> only need to specify those settings that the sensor really needs.
I don't think that's true Hans.
A lot of mainline's kernel boards have been written by passionate people, having
no access to boards layout (for pxa, the includes corgi, tosa, hx4700, mioa701,
all palm series, ...)

For these people, having an "autonegociation algorithm" is one less thing to
bother about.

> > In my opinion you should always want to set this explicitly. This is not
> > something you want to leave to chance. Say you autoconfigure this. Now
> > someone either changes the autoconf algorithm, or a previously undocumented
> > register was discovered for the i2c device and it can suddenly configure the
> > polarity of some signal that was previously thought to be fixed, or something
> > else happens causing a different polarity to be negotiated.
If you're afraid of side effects, you can force the polarity in board code with
the current framework.

If we reduce the current autonegociation code to polarity (forget bus witdh,
...) :
 - if board coder sets unique polarities, they'll be chosen (1)
 - if board coder doesn't set them, the autonegociation algorithm will choose
   (2)

What you want to do is to force all board developers to explicitely polarities,
to only use subset (1) of current negociation algorithm. I see no technical
point motivating this. The existing algorithm is richer.

Personnaly, I'll consider that reducing soc_camera framework to (1) instead of
(1)+(2) is a regretable regression. As part of the board maintaineers having no
access to my board's design, I find the current framework a help.

I still don't understand clearly why delete (2) from current framework. As I
said, "the board designer knows polarities" doesn't stand in our communauty
where board are developped without prior knowledge.

So Hans, why do you want to delete (2) ?

--
Robert

  parent reply	other threads:[~2009-06-14 19:08 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-12 12:46 [PATCH] adding support for setting bus parameters in sub device Hans Verkuil
2009-06-12 12:59 ` Guennadi Liakhovetski
2009-06-12 16:00   ` Hans Verkuil
2009-06-14 15:33     ` Guennadi Liakhovetski
2009-06-14 17:17       ` Hans Verkuil
2009-06-14 19:00         ` Guennadi Liakhovetski
2009-06-14 19:08       ` Robert Jarzmik [this message]
2009-06-17  8:11       ` Magnus Damm
  -- strict thread matches above, loose matches on Subject: below --
2009-06-25 15:21 Hans Verkuil
2009-06-17 21:16 m-karicheri2
2009-06-25 15:12 ` Karicheri, Muralidharan
2009-06-17 11:19 Hans Verkuil
2009-06-17  8:33 Hans Verkuil
2009-06-17  8:46 ` Guennadi Liakhovetski
2009-06-17 13:31   ` Trent Piepho
2009-06-19  3:14 ` Magnus Damm
2009-06-09 20:54 m-karicheri2
2009-06-10 18:32 ` Guennadi Liakhovetski
2009-06-10 19:49   ` Hans Verkuil
2009-06-10 19:59     ` Guennadi Liakhovetski
2009-06-10 20:51       ` Hans Verkuil
2009-06-10 21:15         ` Karicheri, Muralidharan
2009-06-10 21:30         ` Guennadi Liakhovetski
2009-06-10 21:51           ` Hans Verkuil
2009-06-10 23:12             ` Guennadi Liakhovetski
2009-06-11 13:37             ` Karicheri, Muralidharan
2009-06-12 12:15             ` Guennadi Liakhovetski
2009-06-10 20:28   ` Karicheri, Muralidharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ab4a7hwj.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=augulis.darius@gmail.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=magnus.damm@gmail.com \
    --cc=paulius.zaleckas@teltonika.lt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox