Re: soc-camera: pixelfmt translation serie

[Robert Jarzmik <robert.jarzmik@free.fr>]

Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:

> On Sun, 16 Nov 2008, Robert Jarzmik wrote:
>
>> Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
> Yes, I saw this, and although it does look useful, I tend not to add the 
> whole host format - sensor format infrastructure alone for this debug 
> feature. I would restrict this generated format list to user (host) 
> formats only - without exposing which sensor format the host has decided 
> to use for it. We can either add this debug functionality either on a 
> per-host basis, or implement a debug hook in host drivers? In any case I 
> would prefer not to make this a part of the infrastructure for debugging 
> alone.

Ah, but I think it is neceesary. The true purpose of soc_camera is to provide a
generic infrastructure to match sensors to hosts, isn't it ? So there should be
a way to dynamically display all available formats, and where they come from
(ie. which sensor provides it, and with which of its own formats => thinking
debugfs here).

Ideally, you will have a debugfs part telling what are the available formats, to
which (host format, sensor format) they refer, and which couple is the current
one.

>> Would you also duplicate current_fmt, so that the current host format and sensor
>> current format are available at sight ?
>
> Why? Give me a real reason (apart from debugging) why we need to know in 
> soc_camera.c which formats the host requests from the sensor for a 
> specific output format or which format is currently configured on the 
> sensor?
Exactly what you said, debug and tracability.

> Well, would it be enough if I put the current state somewhere up as a 
> quilt patch series, for instance? I don't want to repost all patches on 
> each iteration.
Very well, so just in the cover which of the previous patches should be applied
before your new serie. Or a git repository if you have one ...

Ah, and before I forget. The original idea behind the translation API was to
have the less code in each host for format list creation. I hope you keep in
mind that purpose. The less code in pxa_camera and sh_mobile_ceu_camera.c, the
better. Anyway, I'll see it in your post, and compare to the translation
framework, it's always easier to compare code than specifications :)

--
Robert

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list