From: Michael Ellerman <mpe@ellerman.id.au>
To: Fabio Estevam <festevam@gmail.com>, mchehab@kernel.org
Cc: hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
geert@linux-m68k.org, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v2] media: fsl-viu: Use the ioread/write32be() accessors
Date: Fri, 27 Nov 2020 15:59:28 +1100 [thread overview]
Message-ID: <87czzzxumn.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20201125120447.12437-1-festevam@gmail.com>
Fabio Estevam <festevam@gmail.com> writes:
> Since commit 29d750686331 ("media: fsl-viu: allow building it with
> COMPILE_TEST") there were several attempts to fix build failures on
> PPC, MICROBLAZE and M68K.
>
> However, such errors are still present as reported by kbuild robot.
>
> Fix the problem by using the ioread/write32be() accessors, which build
> fine on all platforms.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - Fix wrong conversion - Michael
>
> drivers/media/platform/fsl-viu.c | 119 ++++++++++++++-----------------
> 1 file changed, 55 insertions(+), 64 deletions(-)
LGTM.
Reviewed-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
prev parent reply other threads:[~2020-11-27 4:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 12:04 [PATCH v2] media: fsl-viu: Use the ioread/write32be() accessors Fabio Estevam
2020-11-27 4:59 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czzzxumn.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=festevam@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox