Re: [PATCH 4/6] siano: remove the remaining CamelCase compliants

["Bjørn Mork" <bjorn@mork.no>]

Mauro Carvalho Chehab <mchehab@redhat.com> writes:

> Remove the remaining CamelCase checkpatch.pl compliants.
> There are still a few left, but those are due to USB and
> DVB APIs.
[..]
> @@ -840,31 +840,31 @@ int smscore_configure_board(struct smscore_device_t *coredev)
>  	}
>  
>  	if (board->mtu) {
> -		struct sms_msg_data MtuMsg;
> +		struct sms_msg_data mtu_msg;
>  		sms_debug("set max transmit unit %d", board->mtu);
>  
> -		MtuMsg.x_msg_header.msg_src_id = 0;
> -		MtuMsg.x_msg_header.msg_dst_id = HIF_TASK;
> -		MtuMsg.x_msg_header.msg_flags = 0;
> -		MtuMsg.x_msg_header.msg_type = MSG_SMS_SET_MAX_TX_MSG_LEN_REQ;
> -		MtuMsg.x_msg_header.msg_length = sizeof(MtuMsg);
> -		MtuMsg.msgData[0] = board->mtu;
> +		mtu_msg.x_msg_header.msg_src_id = 0;
> +		mtu_msg.x_msg_header.msg_dst_id = HIF_TASK;
> +		mtu_msg.x_msg_header.msg_flags = 0;
> +		mtu_msg.x_msg_header.msg_type = MSG_SMS_SET_MAX_TX_MSG_LEN_REQ;
> +		mtu_msg.x_msg_header.msg_length = sizeof(mtu_msg);
> +		mtu_msg.msg_data[0] = board->mtu;
>  

Ah, right.  Why don't you just squash patch 1 and 4 together, reducing
the set with about the size of patch 4, and making all this somewhat
more meaningful?

Tounching the exact same lines twice in the same patchset, doing the
exact same type of cleanup, does *not* help review.


Bjørn