From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Magnus Damm <damm@igel.co.jp>
Subject: Re: [PATCH] soc-camera: fix S_CROP breakage on PXA and SuperH
Date: Mon, 12 Jan 2009 00:59:50 +0100 [thread overview]
Message-ID: <87d4etpf61.fsf@free.fr> (raw)
In-Reply-To: <Pine.LNX.4.64.0901110148360.22041@axis700.grange> (Guennadi Liakhovetski's message of "Sun\, 11 Jan 2009 01\:53\:05 +0100 \(CET\)")
Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
> Recent format-negotiation patches caused S_CROP breakage in pxa_camera.c
> and sh_mobile_ceu_camera.c drivers, fix it.
> Tested on PXA, Magnus, please test on sh, Robert, any objections?
No objection, that seems very sensible, and it was a regression introduced by
the format negotiation, no doubt about it, sorry :(
It's fine by me, and tested (also I don't work with S_CROP so I can only testify
non-regression of my tests).
Cheers.
--
Robert
prev parent reply other threads:[~2009-01-12 0:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 0:53 [PATCH] soc-camera: fix S_CROP breakage on PXA and SuperH Guennadi Liakhovetski
2009-01-11 23:59 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d4etpf61.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=damm@igel.co.jp \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox