From: "Bjørn Mork" <bjorn@mork.no>
To: "Igor M. Liplianin" <liplianin@me.by>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Manu Abraham <abraham.manu@gmail.com>
Subject: Re: [PATCH] Terratec Cinergy C PCI HD (CI)
Date: Wed, 09 May 2012 20:57:49 +0200 [thread overview]
Message-ID: <87fwb95gia.fsf@nemi.mork.no> (raw)
In-Reply-To: <1543153.gDfgtO0cjd@useri> (Igor M. Liplianin's message of "Wed, 09 May 2012 14:23:14 +0300")
"Igor M. Liplianin" <liplianin@me.by> writes:
> This patch seems for rectifying a typo. But actually the difference between
> mantis_vp2040.c and mantis_vp2033.c code is a card name only.
Yes, there are major code duplication issues in this driver.
> Signed-off-by: Igor M. Liplianin <liplianin@me.by>
> diff -r 990a92e2410f linux/drivers/media/dvb/mantis/mantis_cards.c
> --- a/linux/drivers/media/dvb/mantis/mantis_cards.c Wed May 09 01:37:05 2012 +0300
> +++ b/linux/drivers/media/dvb/mantis/mantis_cards.c Wed May 09 14:04:31 2012 +0300
> @@ -276,7 +276,7 @@
> MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_2033_DVB_C, &vp2033_config),
> MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_2040_DVB_C, &vp2040_config),
> MAKE_ENTRY(TECHNISAT, CABLESTAR_HD2, &vp2040_config),
> - MAKE_ENTRY(TERRATEC, CINERGY_C, &vp2033_config),
> + MAKE_ENTRY(TERRATEC, CINERGY_C, &vp2040_config),
> MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_3030_DVB_T, &vp3030_config),
> { }
> };
What's the point? It's a constructed difference. Makes more sense to
refactor and merge all the duplicated code instead of maintaining this
meaningless code split.
> diff -r 990a92e2410f linux/drivers/media/dvb/mantis/mantis_core.c
> --- a/linux/drivers/media/dvb/mantis/mantis_core.c Wed May 09 01:37:05 2012 +0300
> +++ b/linux/drivers/media/dvb/mantis/mantis_core.c Wed May 09 14:04:31 2012 +0300
> @@ -121,7 +121,7 @@
> mantis->hwconfig = &vp2033_mantis_config;
> break;
> case MANTIS_VP_2040_DVB_C: /* VP-2040 */
> - case TERRATEC_CINERGY_C_PCI: /* VP-2040 clone */
> + case CINERGY_C: /* VP-2040 clone */
> case TECHNISAT_CABLESTAR_HD2:
> mantis->hwconfig = &vp2040_mantis_config;
> break;
And this file should never have been merged into the mainline kernel at
all. If you wonder how a bug like that could survive without being
noticed, then the explanation is simple: This code has never been built
as part of the driver in the mainline kernel.
I tried submitting a cleanup patch to have it removed a long time ago:
http://patchwork.linuxtv.org/patch/3680/
but it doesn't seem to have gone anywhere, like most of the patches for
this driver - silently ignored until everyone forgets it and moves on.
The code could certainly benefit from a major cleanup, but I don't see
how that would ever happen. It sort of works. Better leave it there
and spend valuable time elsewhere.
Bjørn
next prev parent reply other threads:[~2012-05-09 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 11:23 [PATCH] Terratec Cinergy C PCI HD (CI) Igor M. Liplianin
2012-05-09 18:57 ` Bjørn Mork [this message]
2012-05-10 15:23 ` Igor M. Liplianin
2012-05-15 11:31 ` Manu Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwb95gia.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=abraham.manu@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=liplianin@me.by \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox