Re: [PATCH 1/6] siano: get rid of CammelCase from smscoreapi.h

["Bjørn Mork" <bjorn@mork.no>]

Mauro Carvalho Chehab <mchehab@redhat.com> writes:

> It is almost impossible to see a compliant with checkpatch.pl
> on those Siano drivers, as there are simply too much violations
> on it. So, now that a big change was done, the better is to
> cleanup the checkpatch compliants.
>
> Let's first replace all CammelCase symbols found at smscoreapi.h
> using camel_case namespace. That removed 144 checkpatch.pl
> compliants on this file. Of course, the other files need to be
> fixed accordingly.
[..]
> @@ -840,14 +840,14 @@ int smscore_configure_board(struct smscore_device_t *coredev)
>  	}
>  
>  	if (board->mtu) {
> -		struct SmsMsgData_ST MtuMsg;
> +		struct sms_msg_data MtuMsg;
>  		sms_debug("set max transmit unit %d", board->mtu);
>  
> -		MtuMsg.xMsgHeader.msgSrcId = 0;
> -		MtuMsg.xMsgHeader.msgDstId = HIF_TASK;
> -		MtuMsg.xMsgHeader.msgFlags = 0;
> -		MtuMsg.xMsgHeader.msgType = MSG_SMS_SET_MAX_TX_MSG_LEN_REQ;
> -		MtuMsg.xMsgHeader.msgLength = sizeof(MtuMsg);
> +		MtuMsg.x_msg_header.msg_src_id = 0;
> +		MtuMsg.x_msg_header.msg_dst_id = HIF_TASK;
> +		MtuMsg.x_msg_header.msg_flags = 0;
> +		MtuMsg.x_msg_header.msg_type = MSG_SMS_SET_MAX_TX_MSG_LEN_REQ;
> +		MtuMsg.x_msg_header.msg_length = sizeof(MtuMsg);
>  		MtuMsg.msgData[0] = board->mtu;
>  
>  		coredev->sendrequest_handler(coredev->context, &MtuMsg,



etc.  This didn't help one bit, did it?  There are exacly the same
number of CamelCased lines here as before your patch.  Why is that?


Bjørn