From: Michael Ellerman <mpe@ellerman.id.au>
To: Fabio Estevam <festevam@gmail.com>, mchehab@kernel.org
Cc: hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
geert@linux-m68k.org, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] media: fsl-viu: Use the ioread/write32be() accessors
Date: Wed, 25 Nov 2020 21:36:41 +1100 [thread overview]
Message-ID: <87im9tzps6.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20201120132907.25323-1-festevam@gmail.com>
Fabio Estevam <festevam@gmail.com> writes:
> diff --git a/drivers/media/platform/fsl-viu.c b/drivers/media/platform/fsl-viu.c
> index ff625301e777..3ce0decb1826 100644
> --- a/drivers/media/platform/fsl-viu.c
> +++ b/drivers/media/platform/fsl-viu.c
> @@ -434,9 +428,9 @@ inline int buffer_activate(struct viu_dev *dev, struct viu_buf *buf)
> if (!V4L2_FIELD_HAS_BOTH(buf->vb.field))
> reg_val.dma_inc = 0;
>
> - out_be32(&vr->dma_inc, reg_val.dma_inc);
> - out_be32(&vr->picture_count, reg_val.picture_count);
> - out_be32(&vr->field_base_addr, reg_val.field_base_addr);
> + iowrite32be(reg_val.dma_inc, &vr->dma_inc);
> + iowrite32be(reg_val.picture_count, &vr->picture_count);
> + iowrite32be(reg_val.field_base_addr, &vr->picture_count);
That last conversion is wrong.
cheers
next prev parent reply other threads:[~2020-11-25 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 13:29 [PATCH] media: fsl-viu: Use the ioread/write32be() accessors Fabio Estevam
2020-11-25 10:36 ` Michael Ellerman [this message]
2020-11-25 12:05 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im9tzps6.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=festevam@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox