From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mARLSvi8020181 for ; Thu, 27 Nov 2008 16:28:57 -0500 Received: from smtp2-g19.free.fr (smtp2-g19.free.fr [212.27.42.28]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id mARLRfRL026430 for ; Thu, 27 Nov 2008 16:27:44 -0500 To: Guennadi Liakhovetski References: <1227554928-25471-1-git-send-email-robert.jarzmik@free.fr> From: Robert Jarzmik Date: Thu, 27 Nov 2008 22:27:40 +0100 In-Reply-To: (Guennadi Liakhovetski's message of "Tue\, 25 Nov 2008 19\:21\:18 +0100 \(CET\)") Message-ID: <87ljv4506r.fsf@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: video4linux-list@redhat.com Subject: Re: [PATCH 1/2] soc_camera: add format translation structure List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: Guennadi Liakhovetski writes: > Well, no. You cannot do this - not in this patch. In general, I guess, you > want current_fmt to point to the xlate object for debugging, etc. But this > has to be a separate patch, changing the define in the header, > soc_camera.c and _all_ host-drivers, including SuperH, which you left > broken with your two patches. So, please leave current_fmt at its old > meaning for these two patches. We can convert it later - if we really want > to. As you wish. I reverted that. > This comment doesn't look quite right - this is not a table, this is just > one element thereof. And "host can generate this list" is also not quite > precise - the list is generated by the soc_camera.c, the host can override > the default one-to-one mapping. Right. > > Otherwise looks ok. I would suggest you remove the current_fmt change, fix > the comment and submit integrated into my previous patch - not as > incremental. > > A review to the pxa-patch will follow later... All right. I'm waiting for the second review to post both patches amended. Meanwhile, I'll always keep the 2 patches state here : http://belgarath.falguerolles.org/download/for_guennadi/ This is the place where the 2 patches are, in their newest form (the merged version from you and me). I took the liberty to cosign the patches, up to you to remove either mine, or yours, or rewrite a part of the patch, to your will. Cheers. -- Robert -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list