From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 982AF45DF6C for ; Fri, 14 Aug 2026 09:26:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786699590; cv=none; b=B1JA8YvXdQD18Vg93CtwSSmkExgS5Omhn97UXZzVr0xo8RXThSDpccHEAHe3MBAqMeBG/vBYc+uZfroWorfEruUZXG4HiHkG+yfdPEYvdRAuTo/WZfvGkGgz7GEI5K/14ISjkbuGKEF1laFFb8F0gPbjHF64EerRRZ2QdEZZly8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786699590; c=relaxed/simple; bh=RvPSVNa0aVdmFm/9aNA4eA+VkRYVGPDNCcLlTZYWOJs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WhIBZ12JSRxfq86bckSiIBM6Al73AJAzck22VL6Oi13l/zSb4c8uEnXmx6+ESvyK/bnh/OCocAktOIsbJf4l3i3v27Txep72PCAkwCaBJ7gZnlJxITLR2wPpfB627JmWiEL6d1ohE6GXOC0DmQEvcuRDexKob+F9nA0l5rw8s1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iD9Rxs7t; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iD9Rxs7t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 132D41F00A3A; Fri, 14 Aug 2026 09:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786699586; bh=DqdRKRcDkM6G7KeJqPjusDGQXr8oQ3YTHxScEhsT6mE=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=iD9Rxs7tqT8xEhFL4BhZrJfRxGxKFxEp2T7JqAxslQaK4EtFbKEmavSecyOMxX0Bs BLVV46j/sVFOVQswvGwZL8rWAjr5VDDK8fpMrakge5Qyp9e5wNqIbbHPL6enOtQLKh 2FLY461FroO8z2JkXgU8Vunv/x6GQToljBnFNL7oJ8sztMWfrPo4BVAYpO8MAfZaaf bEz9o1aUGxq0HE2mPJaFS3qsdtfuNF/CfT3Q2Hv2Yu5DhghibRbUm1zhFBKTFbSBMr jGGrR7km3Y8KiIa7pry4U5WEZJgcr7ywbmrHSXX86fgZS8kHvf1N1QYM4IxN2BU6H9 rpGznI39+YzhQ== From: Mattijs Korpershoek To: Tomi Valkeinen , Mattijs Korpershoek , Sakari Ailus , linux-media@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, Dave Stevenson , Jacopo Mondi , Jai Luthra , Mehdi Djait , Frank Li Subject: Re: [PATCH v2 00/17] Rework frame descriptors In-Reply-To: <2b31cfaf-82ca-4585-b7c8-41a15e5dcc91@ideasonboard.com> References: <20260518164318.3367888-1-sakari.ailus@linux.intel.com> <87pkzl15fs.fsf@kernel.org> <2b31cfaf-82ca-4585-b7c8-41a15e5dcc91@ideasonboard.com> Date: Fri, 14 Aug 2026 11:26:23 +0200 Message-ID: <87mrup129s.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hi Tomi, On Fri, Aug 14, 2026 at 11:21, Tomi Valkeinen wrote: > Hi, > > On 14/08/2026 11:17, Mattijs Korpershoek wrote: >> Hi Sakari, >> >> Thank you for the series. >> >> On Mon, May 18, 2026 at 19:43, Sakari Ailus wrote: >> >>> Hi folks, >>> >>> This smallish set makes frame descriptors dynamically allocated and >>> implements a single-entry frame descriptor based on the device's format, >>> using a new helper called v4l2_subdev_get_frame_desc(). All drivers that >>> do not obtain their frame descriptor from upstream are converted. The >>> helper also obtains a frame descriptor for the desired type (parallel or >>> CSI-2) and checks there's at least one entry there. These checks are >>> removed from drivers that currently perform them. (Some drivers also check >>> there's exactly a single frame descriptor entry but I think in most cases >>> this check could be loosened. That could be done after this set.) >>> >>> On callee side these patches introduce no changes as the number of >>> pre-allocated memory for 8 frame descriptors remains as-is. The >>> get_frame_desc() pad op can return more than 8 frame descriptors by >>> setting the num_entries to the desired number and returning -ENOSPC. >>> >>> If people prefer using cleanup.h / __free() to release the dynamically >>> allocated array (I think I'd almost require that), I'll merge the >>> now-separate __v4l2_subdev_get_frame_desc() into >>> v4l2_subdev_get_frame_desc(). >>> >>> More formats can be added to df-to-mbus conversion as needed. These are >>> meant to be initial formats that are enough for typical raw sensors (and >>> one RGB format, too). >> >> I've tried this out on a AM69-SK with the Arducam FPD V3Link[1] using >> the following device tree overlays: >> ti/k3-am68-sk-v3link-fusion.dtbo ti/k3-v3link-imx219-0-0.dtbo >> >> See TI's documentation about this [2] >> >> I (naively) assumed that this series would replace Tomi's patch [3], but >> it did not. I see the following in dmesg: >> >> [ 286.686574] cdns-csi2rx 4504000.csi-bridge: collect_streams: "cdns_csi2rx.4504000.csi-bridge":1: found 0x1 enabled 0x0 >> [ 286.686754] ds90ub953 7-0044: Failed to get frame desc from remote subdev imx219 10-0010 >> [ 286.700147] ds90ub960 7-0030: Failed to get source frame desc for pad 0 >> [ 286.712679] j721e-csi2rx 4500000.ticsi2rx: enable streams "ds90ub960 7-0030":4/0x1 >> [ 286.712684] ds90ub960 7-0030: collect_streams: "ds90ub960 7-0030":4: found 0x1 enabled 0x0 >> [ 286.712690] ds90ub953 7-0044: Failed to get frame desc from remote subdev imx219 10-0010 >> [ 286.725884] j721e-csi2rx 4500000.ticsi2rx: enable streams 4:0x1 failed: -515 >> >> Here is my camera topology: >> https://paste.debian.net/hidden/7f56f635 >> >> I also made the following patch to attempt to convert over j721e-csi2rx: >> https://paste.debian.net/hidden/314f9c32 >> >> Is this series indeed aimed to replace all sensor-specific >> implementations of .get_frame_desc() or are patches such as the one send >> from Tomi [3] still useful? > I don't remember the details anymore, but probably related to my comment > in this thread: > > "It also looks like you only modified platform drivers. Did you check > the i2c drivers? Some call get_frame_desc().". So I think ub953 is > missing the conversion to v4l2_subdev_get_frame_desc(). Thanks for the hint. ub953 and ub960 (which I both use) indirectly call .get_frame_desc() via v4l2_subdev_get_frame_desc_passthrough(). So maybe v4l2_subdev_get_frame_desc_passthrough() needs an update as well in this series. > > Tomi