Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

[Kevin Hilman <khilman@deeprootsystems.com>]

"Karicheri, Muralidharan" <m-karicheri2@ti.com> writes:

> Can I remove it through a separate patch? This patch is already merged in Hans tree.

Hmm, arch patches should not be merged yet as I have not ack'd them.

Kevin


>>-----Original Message-----
>>From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
>>Sent: Thursday, January 07, 2010 2:44 PM
>>To: Karicheri, Muralidharan
>>Cc: linux-media@vger.kernel.org; hverkuil@xs4all.nl; davinci-linux-open-
>>source@linux.davincidsp.com
>>Subject: Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc
>>drivers to platform driver
>>
>>"Karicheri, Muralidharan" <m-karicheri2@ti.com> writes:
>>
>>> Kevin,
>>>
>>>>
>>>>OK, I'm not extremely familar with the whole video architecture here,
>>>>but are all of these drivers expected to be doing clk_get() and
>>>>clk_enable()?
>>>>
>>>
>>> [MK]Many IPs on DaVinci VPFE would require vpss master clock. So
>>> it is better to do the way I have done in my patch. So it is expected
>>> that clk_get, clk_enable etc are called from other drivers as well.
>>
>>OK, then you are expecting to add clkdev nodes for the other devices
>>as well.  That's ok.
>>
>>However, you still haven't answered my original question.  AFAICT,
>>there are no users of the clkdev nodes "vpss_master" and "vpss_slave".
>>Why not remove those and replace them with your new nodes instead of
>>leaving them and adding new ones?
>>
>>Kevin