From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pz0-f171.google.com ([209.85.222.171]:36431 "EHLO mail-pz0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190Ab0AGVu0 (ORCPT ); Thu, 7 Jan 2010 16:50:26 -0500 Received: by pzk1 with SMTP id 1so3253683pzk.33 for ; Thu, 07 Jan 2010 13:50:25 -0800 (PST) To: "Karicheri\, Muralidharan" Cc: "linux-media\@vger.kernel.org" , "hverkuil\@xs4all.nl" , "davinci-linux-open-source\@linux.davincidsp.com" Subject: Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver References: <1260895054-13232-1-git-send-email-m-karicheri2@ti.com> <871vi4rv25.fsf@deeprootsystems.com> <87k4vvkyo7.fsf@deeprootsystems.com> <878wcbkx60.fsf@deeprootsystems.com> <87r5q1ya2w.fsf@deeprootsystems.com> From: Kevin Hilman Date: Thu, 07 Jan 2010 13:50:23 -0800 In-Reply-To: (Muralidharan Karicheri's message of "Thu\, 7 Jan 2010 15\:33\:53 -0600") Message-ID: <87my0pwpnk.fsf@deeprootsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-media-owner@vger.kernel.org List-ID: "Karicheri, Muralidharan" writes: > Can I remove it through a separate patch? This patch is already merged in Hans tree. Hmm, arch patches should not be merged yet as I have not ack'd them. Kevin >>-----Original Message----- >>From: Kevin Hilman [mailto:khilman@deeprootsystems.com] >>Sent: Thursday, January 07, 2010 2:44 PM >>To: Karicheri, Muralidharan >>Cc: linux-media@vger.kernel.org; hverkuil@xs4all.nl; davinci-linux-open- >>source@linux.davincidsp.com >>Subject: Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc >>drivers to platform driver >> >>"Karicheri, Muralidharan" writes: >> >>> Kevin, >>> >>>> >>>>OK, I'm not extremely familar with the whole video architecture here, >>>>but are all of these drivers expected to be doing clk_get() and >>>>clk_enable()? >>>> >>> >>> [MK]Many IPs on DaVinci VPFE would require vpss master clock. So >>> it is better to do the way I have done in my patch. So it is expected >>> that clk_get, clk_enable etc are called from other drivers as well. >> >>OK, then you are expecting to add clkdev nodes for the other devices >>as well. That's ok. >> >>However, you still haven't answered my original question. AFAICT, >>there are no users of the clkdev nodes "vpss_master" and "vpss_slave". >>Why not remove those and replace them with your new nodes instead of >>leaving them and adding new ones? >> >>Kevin