From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Antonio Ospite <ospite@studenti.unina.it>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: video4linux-list@redhat.com
Subject: Re: [PATCH] mt9m111: Fix YUYV format for pxa-camera
Date: Fri, 31 Oct 2008 18:21:20 +0100 [thread overview]
Message-ID: <87mygkof3j.fsf@free.fr> (raw)
In-Reply-To: <20081029232544.661b8f17.ospite@studenti.unina.it> (Antonio Ospite's message of "Wed\, 29 Oct 2008 23\:25\:44 +0100")
Antonio Ospite <ospite@studenti.unina.it> writes:
> Use 16 bit depth for YUYV so the pxa-camera image buffer has the correct size,
> see the formula:
>
> *size = icd->width * icd->height *
> ((icd->current_fmt->depth + 7) >> 3);
>
> in drivers/media/video/pxa_camera.c: pxa_videobuf_setup().
>
> Don't swap Cb and Cr components, to respect PXA Quick Capture Interface
> data format.
>
> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
As a side note, I wonder how you found the right swap :
- I based the code on Intel PXA Developer Manual, table 27-19 (page 1127)
- and on MT9M111 specification sheet, table 3 (page 14)
My guess is that the PXA manual is wrong somehow ...
Anyway, I'm happy with the patch. Guennadi, could you add this patch to your
queue please ?
--
Robert
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-10-31 17:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 22:25 [PATCH] mt9m111: Fix YUYV format for pxa-camera Antonio Ospite
2008-10-31 17:21 ` Robert Jarzmik [this message]
2008-10-31 17:40 ` Guennadi Liakhovetski
2008-10-31 18:04 ` Robert Jarzmik
2008-10-31 17:45 ` Antonio Ospite
2008-11-02 21:15 ` Guennadi Liakhovetski
2008-11-03 17:23 ` Robert Jarzmik
2008-11-03 19:09 ` Guennadi Liakhovetski
2008-11-03 20:19 ` Robert Jarzmik
2008-11-03 20:52 ` Guennadi Liakhovetski
2008-11-03 22:26 ` Guennadi Liakhovetski
2008-11-03 22:31 ` Robert Jarzmik
2008-11-04 14:42 ` Guennadi Liakhovetski
2008-11-04 17:21 ` Antonio Ospite
2008-11-04 21:57 ` Robert Jarzmik
2008-11-04 21:59 ` [PATCH] Add new pixel format VYUY 16 bits wide Robert Jarzmik
2008-11-04 21:59 ` [PATCH] mt9m111: add all yuv format combinations Robert Jarzmik
2008-11-04 22:40 ` Guennadi Liakhovetski
2008-11-05 22:04 ` Robert Jarzmik
2008-11-05 22:37 ` Guennadi Liakhovetski
2008-12-01 13:59 ` Guennadi Liakhovetski
2008-12-01 18:30 ` Robert Jarzmik
2008-11-04 22:43 ` [PATCH] Add new pixel format VYUY 16 bits wide Guennadi Liakhovetski
2008-11-05 7:19 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mygkof3j.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=g.liakhovetski@gmx.de \
--cc=ospite@studenti.unina.it \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox