public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Jiri Kosina <trivial@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Daniel Mack <zonque@gmail.com>,
	Robert Jarzmik <robert.jarzmik@intel.com>
Subject: Re: [PATCH 4/4] media: pxa_camera: conversion to dmaengine
Date: Sun, 07 Jun 2015 21:17:49 +0200	[thread overview]
Message-ID: <87oakr49b6.fsf@belgarion.home> (raw)
In-Reply-To: <Pine.LNX.4.64.1506041318210.15142@axis700.grange> (Guennadi Liakhovetski's message of "Thu, 4 Jun 2015 13:20:33 +0200 (CEST)")

Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:

> Hi Robert,
>
> Please, correct me if I am wrong, but doesn't this patch have to be 
> updates? Elgl looking at this:
>> +	for (i = 0; i < 3 && buf->descs[i]; i++) {
>> +		async_tx_ack(buf->descs[i]);
>> +		dmaengine_tx_release(buf->descs[i]);
>
> hasn't the addition of your proposed dmaengine_tx_release() API been 
> rejected? I'll wait for an updated version then.
Yeah, correct.
The updated version will just remove the dmaengine_tx_release() call, the
async_tx_ack() is sufficient.

I hope this won't stop the review, it's the only change I have so far in my tree
on top of the submission.

Cheers.

-- 
Robert

  reply	other threads:[~2015-06-07 19:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-21 23:21 [PATCH 0/4] media: pxa_camera conversion to dmaengine Robert Jarzmik
2015-03-21 23:21 ` [PATCH 1/4] media: pxa_camera: fix the buffer free path Robert Jarzmik
2015-03-21 23:21 ` [PATCH 2/4] media: pxa_camera: move interrupt to tasklet Robert Jarzmik
2015-03-21 23:21 ` [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions Robert Jarzmik
2015-06-20 13:29   ` Guennadi Liakhovetski
2015-06-20 21:48     ` Robert Jarzmik
2015-06-21 16:11       ` Guennadi Liakhovetski
2015-06-21 18:05         ` Robert Jarzmik
2015-03-21 23:21 ` [PATCH 4/4] media: pxa_camera: conversion to dmaengine Robert Jarzmik
2015-06-04 11:20   ` Guennadi Liakhovetski
2015-06-07 19:17     ` Robert Jarzmik [this message]
2015-06-21 16:02   ` Guennadi Liakhovetski
2015-06-21 17:16     ` Robert Jarzmik
2015-05-27 19:12 ` [PATCH 0/4] media: pxa_camera " Robert Jarzmik
2015-06-06 21:27   ` Robert Jarzmik
2015-06-07 13:25     ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oakr49b6.fsf@belgarion.home \
    --to=robert.jarzmik@free.fr \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=robert.jarzmik@intel.com \
    --cc=trivial@kernel.org \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox