From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-media@vger.kernel.org, Antonio Ospite <ospite@studenti.unina.it>
Subject: Re: [PATCH] mt9m111: Call icl->reset() on mt9m111_reset().
Date: Tue, 17 Feb 2009 18:17:13 +0100 [thread overview]
Message-ID: <87prhhrnja.fsf@free.fr> (raw)
In-Reply-To: <20090217112339.f959035b.ospite@studenti.unina.it> (Antonio Ospite's message of "Tue\, 17 Feb 2009 11\:23\:39 +0100")
Antonio Ospite <ospite@studenti.unina.it> writes:
> Call icl->reset() on mt9m111_reset().
>
> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
>
> diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c
> index c043f62..92dd7f3 100644
> --- a/drivers/media/video/mt9m111.c
> +++ b/drivers/media/video/mt9m111.c
> @@ -393,6 +393,8 @@ static int mt9m111_disable(struct soc_camera_device *icd)
>
> static int mt9m111_reset(struct soc_camera_device *icd)
> {
> + struct mt9m111 *mt9m111 = container_of(icd, struct mt9m111, icd);
> + struct soc_camera_link *icl = mt9m111->client->dev.platform_data;
> int ret;
>
> ret = reg_set(RESET, MT9M111_RESET_RESET_MODE);
> @@ -401,6 +403,10 @@ static int mt9m111_reset(struct soc_camera_device *icd)
> if (!ret)
> ret = reg_clear(RESET, MT9M111_RESET_RESET_MODE
> | MT9M111_RESET_RESET_SOC);
> +
> + if (icl->reset)
> + icl->reset(&mt9m111->client->dev);
> +
> return ret;
> }
>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Guennadi, would you queue that up for next, please ?
Cheers.
--
Robert
next prev parent reply other threads:[~2009-02-17 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 10:23 [PATCH] mt9m111: Call icl->reset() on mt9m111_reset() Antonio Ospite
2009-02-17 17:17 ` Robert Jarzmik [this message]
2009-02-17 18:05 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prhhrnja.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=ospite@studenti.unina.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox