From: "Bjørn Mork" <bjorn@mork.no>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:
Date: Tue, 06 Sep 2011 09:50:19 +0200 [thread overview]
Message-ID: <87r53uf6tg.fsf@nemi.mork.no> (raw)
In-Reply-To: <4E654F93.9060506@iki.fi> (Antti Palosaari's message of "Tue, 06 Sep 2011 01:39:15 +0300")
Antti Palosaari <crope@iki.fi> writes:
> I am almost sure this have been working earlier, but now it seems like
> nothing is acceptable for checkpatch.pl! I did surely about 20 --amend
> and tried to remove everything, without luck. Could someone point out
> whats new acceptable logging format for checkpatch.pl ?
>
> [crope@localhost linux]$ git show
> 1b19e42952963ae2a09a655f487de15b7c81c5b7 |./scripts/checkpatch.pl -
> WARNING: Do not use whitespace before Signed-off-by:
Don't know if checkpatch used to accept that, but you can use
"--format=email" to make it work with git show:
bjorn@canardo:/usr/local/src/git/linux$ git show --format=email 1b19e42952963ae2a09a655f487de15b7c81c5b7|./scripts/checkpatch.pl -
total: 0 errors, 0 warnings, 48 lines checked
Your patch has no obvious style problems and is ready for submission.
Bjørn
next prev parent reply other threads:[~2011-09-06 7:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 22:39 checkpatch.pl WARNING: Do not use whitespace before Signed-off-by: Antti Palosaari
2011-09-06 7:50 ` Bjørn Mork [this message]
2011-09-06 14:41 ` Antti Palosaari
2011-09-06 15:15 ` Joe Perches
2011-09-06 15:30 ` Antti Palosaari
2011-09-06 16:10 ` Joe Perches
2011-09-06 16:23 ` Antti Palosaari
2011-09-06 16:31 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r53uf6tg.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox