From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Karicheri\, Muralidharan" <m-karicheri2@ti.com>
Cc: "linux-media\@vger.kernel.org" <linux-media@vger.kernel.org>,
"hverkuil\@xs4all.nl" <hverkuil@xs4all.nl>,
"davinci-linux-open-source\@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>
Subject: Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver
Date: Thu, 07 Jan 2010 11:43:51 -0800 [thread overview]
Message-ID: <87r5q1ya2w.fsf@deeprootsystems.com> (raw)
In-Reply-To: <A69FA2915331DC488A831521EAE36FE40162D43099@dlee06.ent.ti.com> (Muralidharan Karicheri's message of "Thu\, 7 Jan 2010 12\:18\:18 -0600")
"Karicheri, Muralidharan" <m-karicheri2@ti.com> writes:
> Kevin,
>
>>
>>OK, I'm not extremely familar with the whole video architecture here,
>>but are all of these drivers expected to be doing clk_get() and
>>clk_enable()?
>>
>
> [MK]Many IPs on DaVinci VPFE would require vpss master clock. So
> it is better to do the way I have done in my patch. So it is expected
> that clk_get, clk_enable etc are called from other drivers as well.
OK, then you are expecting to add clkdev nodes for the other devices
as well. That's ok.
However, you still haven't answered my original question. AFAICT,
there are no users of the clkdev nodes "vpss_master" and "vpss_slave".
Why not remove those and replace them with your new nodes instead of
leaving them and adding new ones?
Kevin
next prev parent reply other threads:[~2010-01-07 19:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 16:37 [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver m-karicheri2
2009-12-15 16:37 ` [PATCH - v3 2/4] V4L - vpfe capture - convert dm355 ccdc driver to a " m-karicheri2
2009-12-15 16:37 ` [PATCH - v3 3/4] V4L - vpfe capture - convert dm644x ccdc module " m-karicheri2
2009-12-15 16:37 ` [PATCH - v3 1/4] V4L - vpfe_capture - remove clock and ccdc resource handling m-karicheri2
2010-01-05 23:28 ` [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver Kevin Hilman
2010-01-06 14:44 ` Karicheri, Muralidharan
2010-01-06 16:04 ` Kevin Hilman
2010-01-06 16:20 ` Karicheri, Muralidharan
2010-01-06 16:36 ` Kevin Hilman
2010-01-07 18:18 ` Karicheri, Muralidharan
2010-01-07 19:43 ` Kevin Hilman [this message]
2010-01-07 21:33 ` Karicheri, Muralidharan
2010-01-07 21:50 ` Kevin Hilman
2010-01-07 23:25 ` Karicheri, Muralidharan
2010-01-08 9:06 ` Hiremath, Vaibhav
2010-01-08 15:10 ` Kevin Hilman
2010-01-11 4:36 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5q1ya2w.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=m-karicheri2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox