Re: [PATCH] LED control

[Peter Korsgaard <jacmet@sunsite.dk>]

>>>>> "Hans" == Hans de Goede <hdegoede@redhat.com> writes:

Hi,

 >> +	<entry><constant>V4L2_CID_LEDS</constant></entry>
 >> +	<entry>integer</entry>
 >> +	<entry>Switch on or off the LED(s) or illuminator(s) of the device.
 >> +	    The control type and values depend on the driver and may be either
 >> +	    a single boolean (0: off, 1:on) or the index in a menu type.</entry>
 >> +	</row>

 Hans> I think that using one control for both status leds (which is
 Hans> what we are usually talking about) and illuminator(s) is a bad
 Hans> idea. I'm fine with standardizing these, but can we please have 2
 Hans> CID's one for status lights and one for the led. Esp, as I can
 Hans> easily see us supporting a microscope in the future where the
 Hans> microscope itself or other devices with the same bridge will have
 Hans> a status led, so then we will need 2 separate controls anyways.

Why does this need to go through the v4l2 api and not just use the
standard LED (sysfs) api in the first place?

-- 
Bye, Peter Korsgaard