Re: pxa_camera: Oops in pxa_camera_probe.

[Robert Jarzmik <robert.jarzmik@free.fr>]

Antonio Ospite <ospite@studenti.unina.it> writes:

> On Fri, 3 Jul 2009 22:03:27 +0200 (CEST)
> Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
>
>> On Fri, 3 Jul 2009, Antonio Ospite wrote:
>> 
>> > > Linux video capture interface: v2.00
>> > > Unable to handle kernel NULL pointer dereference at virtual address 00000060
>> > > pgd = c0004000
>> > > [00000060] *pgd=00000000
>> > > Internal error: Oops: f5 [#1] PREEMPT
>> > > Modules linked in:
>> > > CPU: 0    Tainted: G        W   (2.6.31-rc1-ezxdev #1)
>> > > PC is at dev_driver_string+0x0/0x38
>> > > LR is at pxa_camera_probe+0x144/0x428
>> > 
>> > The offending dev_driver_str() here is the one in the dev_warn() call in
>> > mclk_get_divisor().
>> > 
>> > This is what is happening: in struct pxacamera_platform_data I have:
>> > 	.mclk_10khz = 5000,
>> > 
>> > which makes the > test in mclk_get_divisor() succeed calling dev_warn
>> > to report that the clock has been limited, but pcdev->soc_host.dev is
>> > still uninitialized at this time.
Antonio,

Would you check [1] and see if your stack does correspond to the one I reported
some time ago ? As this is fresh in your memory, you'll be far quicker that me.

Ah, and by the way, I like your patch too, agree that mioa701 is touched, and I
think it should go upstream.

Cheers.

--
Robert

[1] http://osdir.com/ml/linux-media/2009-04/msg00874.html