Re: [PATCH] mt9m111: style cleanup

From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: video4linux-list@redhat.com
Subject: Re: [PATCH] mt9m111: style cleanup
Date: Wed, 13 Aug 2008 18:38:18 +0200	[thread overview]
Message-ID: <87skt86fb9.fsf@free.fr> (raw)
In-Reply-To: <Pine.LNX.4.64.0808131322340.3884@axis700.grange> (Guennadi Liakhovetski's message of "Wed\, 13 Aug 2008 13\:35\:19 +0200 \(CEST\)")

Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:

> Fix a typo in Kconfig, simplify error checking, further minor cleanup.
>
> Signed-off-by: Guennadi Liakhovetski <g.iakhovetski@gmx.de>
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>

But ...

> @@ -778,15 +776,13 @@ static int mt9m111_init(struct soc_camera_device *icd)
>  
>  	mt9m111->context = HIGHPOWER;
>  	ret = mt9m111_enable(icd);
> -	if (ret >= 0)
> +	if (!ret) {
>  		mt9m111_reset(icd);
> -	if (ret >= 0)
>  		mt9m111_set_context(icd, mt9m111->context);
> -	if (ret >= 0)
>  		mt9m111_set_autoexposure(icd, mt9m111->autoexposure);
> -	if (ret < 0)
> +	} else
>  		dev_err(&icd->dev, "mt9m111 init failed: %d\n", ret);
> -	return ret ? -EIO : 0;
> +	return ret;
>  }
You changed the fault path here : you don't check if every call succeeds. I
don't think it's very important though ... I certainly don't care that much.

Plus one style issue : IIRC, if there are braces on the if statement, there must
be braces on the else statement, even if it's a one line else block =>
+	} else {
 		dev_err(&icd->dev, "mt9m111 init failed: %d\n", ret);
+	}

--
Robert

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list