Re: [PATCH 09/19] media: i2c: ov4689: Remove max_fps field from struct ov4689_mode

Laurent Pinchart
2023-12-11T18:19:52Z

Hi Mikhail,

Thank you for the patch.

On Mon, Dec 11, 2023 at 08:50:12PM +0300, Mikhail Rudenko wrote:
> max_fps field of struct ov4689_mode is unused in this driver, so
> remove it.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/media/i2c/ov4689.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c
> index ba33b0ced532..9fa06941a0e5 100644
> --- a/drivers/media/i2c/ov4689.c
> +++ b/drivers/media/i2c/ov4689.c
> @@ -60,7 +60,6 @@ struct ov4689_mode {
> enum ov4689_mode_id id;
> u32 width;
> u32 height;
> - u32 max_fps;
> u32 hts_def;
> u32 vts_def;
> u32 exp_def;
> @@ -237,7 +236,6 @@ static const struct ov4689_mode supported_modes[] = {
> .sensor_height = 1536,
> .crop_top = 8,
> .crop_left = 16,
> - .max_fps = 30,
> .exp_def = 1536,
> .hts_def = 4 * 2574,
> .vts_def = 1554,

--
Regards,

Laurent Pinchart